You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by fmazoyer <gi...@git.apache.org> on 2015/01/06 16:32:44 UTC
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
GitHub user fmazoyer opened a pull request:
https://github.com/apache/storm/pull/373
STORM-248 STORM-322 are fixed and upmerged
Details are in JIRA https://issues.apache.org/jira/browse/STORM-248.
As a collateral benefit, this also addresses JIRA https://issues.apache.org/jira/browse/STORM-322.
Could you please review?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fmazoyer/storm STORM-248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #373
----
commit b2f8eb651d3e8dbd7939aae126d803da6b948663
Author: fmazoyer <fr...@altran.com>
Date: 2014-12-19T16:12:57Z
STORM-248 STORM-322 proposal for fix
commit 49688fd5856e81d947255aca9cca4252d8243945
Author: fmazoyer <fr...@altran.com>
Date: 2014-12-19T16:12:57Z
STORM-248 STORM-322 proposal for fix
commit 14a828cae8d883a8a0d1022d75156079a37a88a8
Author: fmazoyer <fr...@altran.com>
Date: 2015-01-06T12:23:37Z
Merge branch 'STORM-248' of https://github.com/fmazoyer/storm.git into STORM-248
commit fba310af8cc2796af9314bd26217fe08552ad49c
Author: fmazoyer <fr...@altran.com>
Date: 2015-01-06T15:27:19Z
STORM-248 use os.path.join instead or mere path concatenation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/373#discussion_r22600178
--- Diff: bin/storm ---
@@ -312,6 +312,13 @@ def repl():
cppaths = [CLUSTER_CONF_DIR]
exec_storm_class("clojure.main", jvmtype="-client", extrajars=cppaths)
+def get_logback_conf_dir():
+ cppaths = [CLUSTER_CONF_DIR]
+ storm_logback_conf_dir = confvalue("storm.logback.conf.dir", cppaths)
+ if(storm_logback_conf_dir == None or storm_logback_conf_dir == "nil"):
--- End diff --
Sorry, you are right it is "nil".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/373#discussion_r22552440
--- Diff: bin/storm ---
@@ -74,7 +74,8 @@ if (not os.path.isfile(os.path.join(USER_CONF_DIR, "storm.yaml"))):
STORM_RELEASE_DIR = os.path.join(STORM_DIR, "RELEASE")
STORM_LIB_DIR = os.path.join(STORM_DIR, "lib")
STORM_BIN_DIR = os.path.join(STORM_DIR, "bin")
-STORM_LOGBACK_FILE_PATH = os.path.join(STORM_DIR, "logback", "cluster.xml")
+STORM_LOGBACK_DIR = os.path.join(STORM_DIR, "logback")
+STORM_LOGBACK_FILE_PATH = os.path.join(STORM_LOGBACK_DIR, "cluster.xml")
--- End diff --
I don't think this is used any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/373#issuecomment-69044334
Looks good to me +1. I'll give it a few days to let others have a chance to review, and then check it in if there are no other comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/373#issuecomment-68935435
One minor comment, but other then that it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/373#issuecomment-69056901
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by fmazoyer <gi...@git.apache.org>.
Github user fmazoyer commented on the pull request:
https://github.com/apache/storm/pull/373#issuecomment-70099486
Hi Robert,
do you think there are still some things to do on my side ?
Thanks for everything :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/373#discussion_r22597312
--- Diff: bin/storm ---
@@ -312,6 +312,13 @@ def repl():
cppaths = [CLUSTER_CONF_DIR]
exec_storm_class("clojure.main", jvmtype="-client", extrajars=cppaths)
+def get_logback_conf_dir():
+ cppaths = [CLUSTER_CONF_DIR]
+ storm_logback_conf_dir = confvalue("storm.logback.conf.dir", cppaths)
+ if(storm_logback_conf_dir == None or storm_logback_conf_dir == "nil"):
--- End diff --
Here storm_logback_conf_dir == "nil" will match if the storm_logback_conf_dir is set to "nil" . I think you meant to check if the string is empty, a better way probably is "if not storm_logback_conf"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/373#discussion_r22597616
--- Diff: bin/storm ---
@@ -312,6 +312,13 @@ def repl():
cppaths = [CLUSTER_CONF_DIR]
exec_storm_class("clojure.main", jvmtype="-client", extrajars=cppaths)
+def get_logback_conf_dir():
+ cppaths = [CLUSTER_CONF_DIR]
+ storm_logback_conf_dir = confvalue("storm.logback.conf.dir", cppaths)
+ if(storm_logback_conf_dir == None or storm_logback_conf_dir == "nil"):
--- End diff --
No it is actually "nil". You can try it.
```
$ storm localconfvalue something.bogus
something.bogus: nil
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/373#issuecomment-70313247
@harshach, would you resolve STORM-248? I Resolved STORM-322 already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/373#issuecomment-70283290
@fmazoyer Thanks for the patch. I pushed it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/373#discussion_r22597673
--- Diff: bin/storm ---
@@ -312,6 +312,13 @@ def repl():
cppaths = [CLUSTER_CONF_DIR]
exec_storm_class("clojure.main", jvmtype="-client", extrajars=cppaths)
+def get_logback_conf_dir():
+ cppaths = [CLUSTER_CONF_DIR]
+ storm_logback_conf_dir = confvalue("storm.logback.conf.dir", cppaths)
+ if(storm_logback_conf_dir == None or storm_logback_conf_dir == "nil"):
--- End diff --
If we want it to behave differently we need to fix confvalue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-248 STORM-322 are fixed and upmerged
Posted by fmazoyer <gi...@git.apache.org>.
Github user fmazoyer commented on the pull request:
https://github.com/apache/storm/pull/373#issuecomment-69002802
Thank you for your comment, this is done :-)
Could you please review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---