[GitHub] [airflow] malthe commented on a diff in pull request #28234: Make arguments 'offset' and 'length' not required

[GitBox <gi...@apache.org>]

malthe commented on code in PR #28234:
URL: https://github.com/apache/airflow/pull/28234#discussion_r1043810079


##########
airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -385,7 +385,7 @@ def upload(
         return blob_client.upload_blob(data, blob_type, length=length, **kwargs)
 
     def download(
-        self, container_name, blob_name, offset: int, length: int, **kwargs
+        self, container_name, blob_name, offset: int | None = None, length: int | None = None, **kwargs

Review Comment:
   What's the deal with those exclusions:
   ```
   [mypy-azure.batch.*]
   no_implicit_optional = False
   [mypy-azure.batch.models.*]
   no_implicit_optional = False
   ```
   Does it pattern-match on the module where the problem is? I am not totally sure what to put here for azure-storage, @potiuk.
   ```cfg
   [mypy-azure.storage.*]
   no_implicit_optional = False
   ```
   ^^^ something like that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org