You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Noble Paul (Jira)" <ji...@apache.org> on 2020/07/12 10:14:00 UTC

[jira] [Comment Edited] (SOLR-14155) Load all other SolrCore plugins from packages

    [ https://issues.apache.org/jira/browse/SOLR-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156281#comment-17156281 ] 

Noble Paul edited comment on SOLR-14155 at 7/12/20, 10:13 AM:
--------------------------------------------------------------

I had the choice of modifying SRL to do the same . Instead I added a couple of sttaic methods to a new class called {{CoreRefreshingClassLoader}} because 

* The reader of the code clearly knows that it may result in reloading the core when classes are modified
*  SRL is used all over the places and it will continue to get used in new places and an average developer will now know the implications of his code

Reloading a core may sound simple in normal cases. In a lot of orgs the configset is shared across 10000's of indexes (cores). So a core reload  means we are reloading petabytes (or much more) of data. This can cause downtime. So, we have to be careful about where a reload may happen and we should be explicit about our intent


was (Author: noble.paul):
I had the choice of modifying SRL to do the same . Instead I added a couple of sttaic methods to a new class called {{CoreRefreshingClassLoader}} because 

* The reader of the code clearly knows that it may result in reloading the core when classes are modified
*  SRL is used all over the places and it wil continue to get used in new places and an average developer will now know the implications of his code

> Load all other SolrCore plugins from packages
> ---------------------------------------------
>
>                 Key: SOLR-14155
>                 URL: https://issues.apache.org/jira/browse/SOLR-14155
>             Project: Solr
>          Issue Type: Sub-task
>          Components: packages
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>             Fix For: 8.7
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> A few plugins configurable in {{solrconfig.xml}} still cannot be loaded from packages 
>  # SolrEventListener (improperly implemented)
>  # DirectoryFactor
>  # Updatelog
>  # Cache
>  # RecoveryStrategy
>  # IndexReaderFactory
>  # CodecFactory
>  # StatsCache
> #1 can do hot reload.  other should result in reloading the core. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org