You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/09/06 16:43:09 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7462: Make sqllogictest platform-independent for the sign of NaN

alamb commented on code in PR #7462:
URL: https://github.com/apache/arrow-datafusion/pull/7462#discussion_r1317564967


##########
datafusion/sqllogictest/test_files/select.slt:
##########
@@ -224,12 +224,6 @@ select
 ----
 false true false true true false false true false true true false true true false false true
 
-# select NaNs
-query RRRR
-select 'NaN'::double a, '-NaN'::double b, 'NaN'::float c, '-NaN'::float d
-----
-NaN -NaN NaN -NaN

Review Comment:
   I think we should leave the test to show the behavior of parsing `-NaN`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org