You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@avro.apache.org by dc...@apache.org on 2012/03/01 04:52:24 UTC

svn commit: r1295400 - in /avro/trunk: CHANGES.txt lang/c/src/avro/refcount.h

Author: dcreager
Date: Thu Mar  1 03:52:24 2012
New Revision: 1295400

URL: http://svn.apache.org/viewvc?rev=1295400&view=rev
Log:
AVRO-1038. C: Require GCC 4.5.0 to use GCC atomic intrinsics.

Vivek has found a couple of platforms where the GCC atomic instrinsics
aren't available in 4.1.0.  We can fall back on the raw assembly
implementations our supported platforms, so for now, we're going to bump
the required GCC version to 4.5.0.  We'll eventually want to replace
this with an autotools-style runtime check in our CMake files, or a more
complex preprocessor check.

Contributed by Vivek Nadkarni.

Modified:
    avro/trunk/CHANGES.txt
    avro/trunk/lang/c/src/avro/refcount.h

Modified: avro/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/avro/trunk/CHANGES.txt?rev=1295400&r1=1295399&r2=1295400&view=diff
==============================================================================
--- avro/trunk/CHANGES.txt (original)
+++ avro/trunk/CHANGES.txt Thu Mar  1 03:52:24 2012
@@ -21,6 +21,9 @@ Avro 1.6.3 (unreleased)
     AVRO-1033. C: Fixed x86 assembly implementation of atomic reference
     counting primitives. (Vivek Nadkarni via dcreager)
 
+    AVRO-1038. C: Require GCC 4.5.0 to use GCC atomic instrinsics.
+    (Vivek Nadkarni via dcreager)
+
 Avro 1.6.2 (13 February 2012)
 
   NEW FEATURES

Modified: avro/trunk/lang/c/src/avro/refcount.h
URL: http://svn.apache.org/viewvc/avro/trunk/lang/c/src/avro/refcount.h?rev=1295400&r1=1295399&r2=1295400&view=diff
==============================================================================
--- avro/trunk/lang/c/src/avro/refcount.h (original)
+++ avro/trunk/lang/c/src/avro/refcount.h Thu Mar  1 03:52:24 2012
@@ -84,7 +84,7 @@ avro_refcount_dec(volatile int *refcount
  * GCC intrinsics
  */
 
-#elif (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) > 40100
+#elif (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) > 40500
 
 static inline void
 avro_refcount_set(volatile int *refcount, int value)