You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/19 16:17:20 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #5562: Python: First version of the Table API

Fokko commented on code in PR #5562:
URL: https://github.com/apache/iceberg/pull/5562#discussion_r950364276


##########
python/pyiceberg/table/__init__.py:
##########
@@ -14,17 +14,102 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-from typing import Optional, Union
+from functools import cached_property
+from typing import (
+    Dict,
+    List,
+    Optional,
+    Union,
+)
 
 from pydantic import Field
 
+from pyiceberg.schema import Schema
 from pyiceberg.table.metadata import TableMetadataV1, TableMetadataV2
+from pyiceberg.table.partitioning import PartitionSpec
+from pyiceberg.table.snapshots import Snapshot, SnapshotLogEntry
+from pyiceberg.table.sorting import SortOrder
 from pyiceberg.typedef import Identifier
 from pyiceberg.utils.iceberg_base_model import IcebergBaseModel
 
 
 class Table(IcebergBaseModel):
     identifier: Identifier = Field()
     metadata_location: str = Field()
-    metadata: Optional[Union[TableMetadataV1, TableMetadataV2]] = Field()
+    metadata: Union[TableMetadataV1, TableMetadataV2] = Field()
+
+    def refresh(self, catalog) -> "Table":

Review Comment:
   Reverted 👍🏻 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org