You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/03 20:08:13 UTC
[GitHub] [helix] narendly commented on a change in pull request #1326: Task Framework IdealState Removal
narendly commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r483225266
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
##########
@@ -59,6 +62,7 @@ public void process(ClusterEvent event) throws Exception {
Map<String, Resource> resourceMap = new LinkedHashMap<>();
Map<String, Resource> resourceToRebalance = new LinkedHashMap<>();
+ Map<String, Resource> taskResourcesToDrop = new LinkedHashMap<>();
Review comment:
Does this need to be a LinkedHashMap?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org