You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2019/01/23 18:26:47 UTC
Review Request 69825: Added test to ensure backwards compatibility of
resources checkpointing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69825/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Greg Mann.
Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356
Repository: mesos
Description
-------
Added test to ensure backwards compatibility of resources checkpointing.
Diffs
-----
src/tests/reservation_tests.cpp 3f33885099c3377c6477475ae43dcaa88d920547
Diff: https://reviews.apache.org/r/69825/diff/1/
Testing
-------
The test passed 10,000 consecutive runs.
Thanks,
Gastón Kleiman
Re: Review Request 69825: Added test to ensure backwards
compatibility of resources checkpointing.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69825/#review212342
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 24, 2019, 10:39 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69825/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2019, 10:39 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test to ensure backwards compatibility of resources checkpointing.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp 3f33885099c3377c6477475ae43dcaa88d920547
>
>
> Diff: https://reviews.apache.org/r/69825/diff/2/
>
>
> Testing
> -------
>
> The test passed 10,000 consecutive runs.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69825: Added test to ensure backwards
compatibility of resources checkpointing.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69825/#review212298
-----------------------------------------------------------
PASS: Mesos patch 69825 was successfully built and tested.
Reviews applied: `['69790', '69791', '69792', '69793', '69794', '69795', '69825']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2815/mesos-review-69825
- Mesos Reviewbot Windows
On Jan. 24, 2019, 10:39 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69825/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2019, 10:39 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test to ensure backwards compatibility of resources checkpointing.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp 3f33885099c3377c6477475ae43dcaa88d920547
>
>
> Diff: https://reviews.apache.org/r/69825/diff/2/
>
>
> Testing
> -------
>
> The test passed 10,000 consecutive runs.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69825: Added test to ensure backwards
compatibility of resources checkpointing.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69825/
-----------------------------------------------------------
(Updated Jan. 24, 2019, 2:39 p.m.)
Review request for mesos, Benno Evers and Greg Mann.
Changes
-------
Addressed feedback.
Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356
Repository: mesos
Description
-------
Added test to ensure backwards compatibility of resources checkpointing.
Diffs (updated)
-----
src/tests/reservation_tests.cpp 3f33885099c3377c6477475ae43dcaa88d920547
Diff: https://reviews.apache.org/r/69825/diff/2/
Changes: https://reviews.apache.org/r/69825/diff/1-2/
Testing
-------
The test passed 10,000 consecutive runs.
Thanks,
Gastón Kleiman
Re: Review Request 69825: Added test to ensure backwards
compatibility of resources checkpointing.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69825/#review212265
-----------------------------------------------------------
src/tests/reservation_tests.cpp
Lines 2517 (patched)
<https://reviews.apache.org/r/69825/#comment298003>
Is this necessary? I didn't think the master needed to be initialized with roles anymore?
src/tests/reservation_tests.cpp
Lines 2580 (patched)
<https://reviews.apache.org/r/69825/#comment298004>
s/processses/processes/
- Greg Mann
On Jan. 23, 2019, 6:26 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69825/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 6:26 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test to ensure backwards compatibility of resources checkpointing.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp 3f33885099c3377c6477475ae43dcaa88d920547
>
>
> Diff: https://reviews.apache.org/r/69825/diff/1/
>
>
> Testing
> -------
>
> The test passed 10,000 consecutive runs.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69825: Added test to ensure backwards
compatibility of resources checkpointing.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69825/#review212252
-----------------------------------------------------------
PASS: Mesos patch 69825 was successfully built and tested.
Reviews applied: `['69790', '69791', '69792', '69793', '69794', '69795', '69825']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2812/mesos-review-69825
- Mesos Reviewbot Windows
On Jan. 23, 2019, 6:26 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69825/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 6:26 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test to ensure backwards compatibility of resources checkpointing.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp 3f33885099c3377c6477475ae43dcaa88d920547
>
>
> Diff: https://reviews.apache.org/r/69825/diff/1/
>
>
> Testing
> -------
>
> The test passed 10,000 consecutive runs.
>
>
> Thanks,
>
> Gastón Kleiman
>
>