[jira] [Commented] (HBASE-14209) TestShell visibility tests failing

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692924#comment-14692924 ] 

ramkrishna.s.vasudevan commented on HBASE-14209:
------------------------------------------------

Thanks for looking at this [~apurtell].
Not guarding the ordinalVsLabels with the RW lock was done on purpose I think (i remember that way) because as the getUserAuthsAsOrdinals is protected with the RW lock. And also adding the new user labels is an admin op and not so critical in such a way that multiple labels are added at the same time and some one tries to read the userAuths for performing mutations (added to that the userAuths is already protected). But I think better to do it.
Regarding that local update, I think considering this the first two changes of guarding 'ordinalVsLabels' is needed. 


> TestShell visibility tests failing
> ----------------------------------
>
>                 Key: HBASE-14209
>                 URL: https://issues.apache.org/jira/browse/HBASE-14209
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.14
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
>
>         Attachments: HBASE-14209-0.98.patch
>
>
> This is after HBASE-14105  but we've seen this earlier where adding ruby units to the shell tests can cause the visibility tests to fail inexplicably. We can't just avoid adding ruby units to TestShell in 0.98 so figure out the root cause and fix or disable these. 
> {noformat}
>   1) Error:
> test_The_get/put_methods_should_work_for_data_written_with_Visibility(Hbase::VisibilityLabelsAdminMethodsTest):
> NativeException: junit.framework.AssertionFailedError: Waiting timed out after [10,000] msec
>     junit/framework/Assert.java:57:in `fail'
>     org/apache/hadoop/hbase/Waiter.java:193:in `waitFor'
>     org/apache/hadoop/hbase/Waiter.java:128:in `waitFor'
>     org/apache/hadoop/hbase/HBaseTestingUtility.java:3514:in `waitFor'
>     org/apache/hadoop/hbase/HBaseTestingUtility.java:3576:in `waitLabelAvailable'
>     ./src/test/ruby/hbase/visibility_labels_admin_test.rb:73:in `test_The_get/put_methods_should_work_for_data_written_with_Visibility'
>     org/jruby/RubyProc.java:270:in `call'
>     org/jruby/RubyKernel.java:2105:in `send'
>     org/jruby/RubyArray.java:1620:in `each'
>     org/jruby/RubyArray.java:1620:in `each'
>   2) Error:
> test_The_set/clear_methods_should_work_with_authorizations(Hbase::VisibilityLabelsAdminMethodsTest):
> NativeException: junit.framework.AssertionFailedError: Waiting timed out after [10,000] msec
>     junit/framework/Assert.java:57:in `fail'
>     org/apache/hadoop/hbase/Waiter.java:193:in `waitFor'
>     org/apache/hadoop/hbase/Waiter.java:128:in `waitFor'
>     org/apache/hadoop/hbase/HBaseTestingUtility.java:3514:in `waitFor'
>     org/apache/hadoop/hbase/HBaseTestingUtility.java:3576:in `waitLabelAvailable'
>     ./src/test/ruby/hbase/visibility_labels_admin_test.rb:52:in `test_The_set/clear_methods_should_work_with_authorizations'
>     org/jruby/RubyProc.java:270:in `call'
>     org/jruby/RubyKernel.java:2105:in `send'
>     org/jruby/RubyArray.java:1620:in `each'
>     org/jruby/RubyArray.java:1620:in `each'
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)