You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/10 13:12:28 UTC

[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1314: fix: deadlock

LaurenceLiZhixin opened a new pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/05e103d3709ef42efce449080401fc656dbe1784?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05e103d) will **decrease** coverage by `0.07%`.
   > The diff coverage is `54.13%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head 3de9981. Consider uploading reports for the commit 3de9981 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   - Coverage   59.01%   58.93%   -0.08%     
   ==========================================
     Files         269      282      +13     
     Lines       13157    16213    +3056     
   ==========================================
   + Hits         7764     9555    +1791     
   - Misses       4424     5666    +1242     
   - Partials      969      992      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/cluster\_interceptor.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyX2ludGVyY2VwdG9yLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `19.40% <0.00%> (+5.84%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `62.16% <0.00%> (+1.27%)` | :arrow_up: |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+3.99%)` | :arrow_up: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (+4.84%)` | :arrow_up: |
   | [config/generic\_service\_ext.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZV9leHQuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `50.00% <ø> (+5.88%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <ø> (+7.52%)` | :arrow_up: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `56.57% <0.00%> (-0.95%)` | :arrow_down: |
   | ... and [375 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...3de9981](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

AlexStocks merged pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5690219) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.66%`.
   > The diff coverage is `76.00%`.
   
   > :exclamation: Current head 5690219 differs from pull request most recent head db4a238. Consider uploading reports for the commit db4a238 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.74%   +0.66%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16279    +2898     
   ==========================================
   + Hits         7771     9563    +1792     
   - Misses       4650     5722    +1072     
   - Partials      960      994      +34     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.91% <71.42%> (+7.12%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `74.73% <100.00%> (+3.90%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | ... and [282 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...db4a238](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/05e103d3709ef42efce449080401fc656dbe1784?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05e103d) will **decrease** coverage by `0.07%`.
   > The diff coverage is `54.13%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head e24c338. Consider uploading reports for the commit e24c338 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   - Coverage   59.01%   58.93%   -0.08%     
   ==========================================
     Files         269      282      +13     
     Lines       13157    16213    +3056     
   ==========================================
   + Hits         7764     9555    +1791     
   - Misses       4424     5666    +1242     
   - Partials      969      992      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/cluster\_interceptor.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyX2ludGVyY2VwdG9yLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `19.40% <0.00%> (+5.84%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `62.16% <0.00%> (+1.27%)` | :arrow_up: |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+3.99%)` | :arrow_up: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (+4.84%)` | :arrow_up: |
   | [config/generic\_service\_ext.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZV9leHQuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `50.00% <ø> (+5.88%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <ø> (+7.52%)` | :arrow_up: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `56.57% <0.00%> (-0.95%)` | :arrow_down: |
   | ... and [375 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...e24c338](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.85%`.
   > The diff coverage is `75.51%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head dcd2edb. Consider uploading reports for the commit dcd2edb to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.93%   +0.85%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16213    +2832     
   ==========================================
   + Hits         7771     9555    +1784     
   - Misses       4650     5666    +1016     
   - Partials      960      992      +32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `78.38% <58.33%> (+2.63%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.91% <71.42%> (+7.12%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | [config/instance/metadata\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2luc3RhbmNlL21ldGFkYXRhX3JlcG9ydC5nbw==) | `66.66% <0.00%> (-11.12%)` | :arrow_down: |
   | ... and [281 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...dcd2edb](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (baab044) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.47%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.54%   +0.47%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16279    +2898     
   ==========================================
   + Hits         7771     9531    +1760     
   - Misses       4650     5753    +1103     
   - Partials      960      995      +35     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <50.00%> (+2.14%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `66.66% <71.42%> (+0.87%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `74.73% <100.00%> (+3.90%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | ... and [282 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...baab044](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.85%`.
   > The diff coverage is `75.51%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head 71bc2e7. Consider uploading reports for the commit 71bc2e7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.93%   +0.85%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16213    +2832     
   ==========================================
   + Hits         7771     9555    +1784     
   - Misses       4650     5666    +1016     
   - Partials      960      992      +32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `78.38% <58.33%> (+2.63%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.91% <71.42%> (+7.12%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | [config/instance/metadata\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2luc3RhbmNlL21ldGFkYXRhX3JlcG9ydC5nbw==) | `66.66% <0.00%> (-11.12%)` | :arrow_down: |
   | ... and [281 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...71bc2e7](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (baab044) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.47%`.
   > The diff coverage is `77.27%`.
   
   > :exclamation: Current head baab044 differs from pull request most recent head 43cf743. Consider uploading reports for the commit 43cf743 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.54%   +0.47%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16279    +2898     
   ==========================================
   + Hits         7771     9531    +1760     
   - Misses       4650     5753    +1103     
   - Partials      960      995      +35     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <50.00%> (+2.14%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `66.66% <71.42%> (+0.87%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `74.73% <100.00%> (+3.90%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | ... and [282 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...43cf743](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] wenxuwan commented on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

wenxuwan commented on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-881524703


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/05e103d3709ef42efce449080401fc656dbe1784?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05e103d) will **decrease** coverage by `0.07%`.
   > The diff coverage is `54.13%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head b262aff. Consider uploading reports for the commit b262aff to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   - Coverage   59.01%   58.93%   -0.08%     
   ==========================================
     Files         269      282      +13     
     Lines       13157    16213    +3056     
   ==========================================
   + Hits         7764     9555    +1791     
   - Misses       4424     5666    +1242     
   - Partials      969      992      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/cluster\_interceptor.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyX2ludGVyY2VwdG9yLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `19.40% <0.00%> (+5.84%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `62.16% <0.00%> (+1.27%)` | :arrow_up: |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+3.99%)` | :arrow_up: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (+4.84%)` | :arrow_up: |
   | [config/generic\_service\_ext.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZV9leHQuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `50.00% <ø> (+5.88%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <ø> (+7.52%)` | :arrow_up: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `56.57% <0.00%> (-0.95%)` | :arrow_down: |
   | ... and [375 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...b262aff](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5690219) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.66%`.
   > The diff coverage is `76.00%`.
   
   > :exclamation: Current head 5690219 differs from pull request most recent head 9ee7433. Consider uploading reports for the commit 9ee7433 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.74%   +0.66%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16279    +2898     
   ==========================================
   + Hits         7771     9563    +1792     
   - Misses       4650     5722    +1072     
   - Partials      960      994      +34     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.91% <71.42%> (+7.12%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `74.73% <100.00%> (+3.90%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | ... and [282 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...9ee7433](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.85%`.
   > The diff coverage is `75.51%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head 3ce818a. Consider uploading reports for the commit 3ce818a to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.93%   +0.85%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16213    +2832     
   ==========================================
   + Hits         7771     9555    +1784     
   - Misses       4650     5666    +1016     
   - Partials      960      992      +32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `78.38% <58.33%> (+2.63%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.91% <71.42%> (+7.12%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | [config/instance/metadata\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2luc3RhbmNlL21ldGFkYXRhX3JlcG9ydC5nbw==) | `66.66% <0.00%> (-11.12%)` | :arrow_down: |
   | ... and [281 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...3ce818a](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (baab044) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.47%`.
   > The diff coverage is `77.27%`.
   
   > :exclamation: Current head baab044 differs from pull request most recent head db4a238. Consider uploading reports for the commit db4a238 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.54%   +0.47%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16279    +2898     
   ==========================================
   + Hits         7771     9531    +1760     
   - Misses       4650     5753    +1103     
   - Partials      960      995      +35     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <50.00%> (+2.14%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `66.66% <71.42%> (+0.87%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `74.73% <100.00%> (+3.90%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | ... and [282 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...db4a238](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **increase** coverage by `0.85%`.
   > The diff coverage is `75.51%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head baab044. Consider uploading reports for the commit baab044 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   + Coverage   58.07%   58.93%   +0.85%     
   ==========================================
     Files         275      282       +7     
     Lines       13381    16213    +2832     
   ==========================================
   + Hits         7771     9555    +1784     
   - Misses       4650     5666    +1016     
   - Partials      960      992      +32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `42.79% <ø> (+1.51%)` | :arrow_up: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `78.38% <58.33%> (+2.63%)` | :arrow_up: |
   | [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `77.14% <66.66%> (+3.80%)` | :arrow_up: |
   | [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `74.00% <71.42%> (+6.50%)` | :arrow_up: |
   | [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.91% <71.42%> (+7.12%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `73.41% <71.42%> (+4.18%)` | :arrow_up: |
   | [metadata/identifier/base\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvaWRlbnRpZmllci9iYXNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `92.85% <100.00%> (+8.24%)` | :arrow_up: |
   | [registry/event.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQuZ28=) | `29.62% <100.00%> (ø)` | |
   | [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.73% <100.00%> (+2.57%)` | :arrow_up: |
   | [config/instance/metadata\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2luc3RhbmNlL21ldGFkYXRhX3JlcG9ydC5nbw==) | `66.66% <0.00%> (-11.12%)` | :arrow_down: |
   | ... and [281 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...baab044](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1314: fix: deadlock

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #1314:
URL: https://github.com/apache/dubbo-go/pull/1314#issuecomment-877660466


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1314](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cbc14a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/05e103d3709ef42efce449080401fc656dbe1784?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05e103d) will **decrease** coverage by `0.07%`.
   > The diff coverage is `54.13%`.
   
   > :exclamation: Current head 7cbc14a differs from pull request most recent head a65be1a. Consider uploading reports for the commit a65be1a to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1314/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1314      +/-   ##
   ==========================================
   - Coverage   59.01%   58.93%   -0.08%     
   ==========================================
     Files         269      282      +13     
     Lines       13157    16213    +3056     
   ==========================================
   + Hits         7764     9555    +1791     
   - Misses       4424     5666    +1242     
   - Partials      969      992      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/cluster\_interceptor.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyX2ludGVyY2VwdG9yLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `19.40% <0.00%> (+5.84%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `62.16% <0.00%> (+1.27%)` | :arrow_up: |
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+3.99%)` | :arrow_up: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (+4.84%)` | :arrow_up: |
   | [config/generic\_service\_ext.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZV9leHQuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `50.00% <ø> (+5.88%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <ø> (+7.52%)` | :arrow_up: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `56.57% <0.00%> (-0.95%)` | :arrow_down: |
   | ... and [375 more](https://codecov.io/gh/apache/dubbo-go/pull/1314/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cef22ea...a65be1a](https://codecov.io/gh/apache/dubbo-go/pull/1314?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org