[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #80: CI: add test ci

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#discussion_r540634398



##########
File path: .github/workflows/test-ci.yml
##########
@@ -0,0 +1,23 @@
+name: test-ci
+
+on:
+  push:
+    branches:
+      - master
+      - kv/ci
+  pull_request:
+    branches:
+      - master
+jobs:
+  run-test:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: setup go
+      uses: actions/setup-go@v1
+      with:
+        go-version: '1.13'
+    - name: run test
+      working-directory: ./
+      run: |
+        go test ./...

Review comment:
       Please check the editor, always add the linebreak.

##########
File path: pkg/ingress/apisix/upstream_test.go
##########
@@ -94,6 +97,7 @@ kind: ApisixUpstream
 apiVersion: apisix.apache.org/v1
 metadata:
   name: httpserver
+  namespace: cloud

Review comment:
       Still use cloud namespace? we should use ingress-apisix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org