[GitHub] [arrow-rs] ming08108 commented on a diff in pull request #4412: Remove 64-bit to 32-bit Cast from IPC Reader

["ming08108 (via GitHub)" <gi...@apache.org>]

ming08108 commented on code in PR #4412:
URL: https://github.com/apache/arrow-rs/pull/4412#discussion_r1230300405


##########
arrow-ipc/src/reader.rs:
##########
@@ -250,24 +242,23 @@ fn create_primitive_array(
         | UInt32
         | Time32(_)
         | Date32
-        | Interval(IntervalUnit::YearMonth) => {
-            if buffers[1].len() / 8 == length && length != 1 {

Review Comment:
   Encountered this when reading a zero copy sliced RecordBatch from c++. If an int32 array was sliced to half its original size it would trigger this since the original backing buffer remained at its original size in the ipc message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org