You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Eric Covener (JIRA)" <ji...@apache.org> on 2010/04/16 02:28:05 UTC

[jira] Created: (OWB-357) WebbeansFinder should index first on ClassLoader, not singleton type

WebbeansFinder should index first on ClassLoader, not singleton type
--------------------------------------------------------------------

                 Key: OWB-357
                 URL: https://issues.apache.org/jira/browse/OWB-357
             Project: OpenWebBeans
          Issue Type: Bug
    Affects Versions: M4
         Environment: tiered classloader
            Reporter: Eric Covener
            Assignee: Eric Covener
            Priority: Minor
             Fix For: M4


I'm finding WebbeansFinder a little difficult  to work with since it is unable to easily clear all instances a / the current classloader.

I would like to change the map to have the primary index on the classloader from:

private static Map<String, Map<ClassLoader, Object>> singletonMap = new HashMap<String, Map<ClassLoader, Object>>();
to
private static Map<ClassLoader, Map<String, Object>> singletonMap = new HashMap<ClassLoader, Map<String, Object>>();

Currently, this only really breaks removeInstance(String name) which AFAICT has no callers.  This would be replaced by e.g.

clearInstance(ClassLoader cl)

And most current callers of clearInstances() would I think prefer to just clear an individual classloader.

Opinions welcome, and curious if anyone wants to preserve a removeInstance(String name) method.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OWB-357) WebbeansFinder should index first on ClassLoader, not singleton type

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gurkan Erdogdu updated OWB-357:
-------------------------------

    Fix Version/s: 1.0.0
                       (was: M4)

> WebbeansFinder should index first on ClassLoader, not singleton type
> --------------------------------------------------------------------
>
>                 Key: OWB-357
>                 URL: https://issues.apache.org/jira/browse/OWB-357
>             Project: OpenWebBeans
>          Issue Type: Bug
>    Affects Versions: M4
>         Environment: tiered classloader
>            Reporter: Eric Covener
>            Assignee: Eric Covener
>            Priority: Minor
>             Fix For: 1.0.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> I'm finding WebbeansFinder a little difficult  to work with since it is unable to easily clear all instances a / the current classloader.
> I would like to change the map to have the primary index on the classloader from:
> private static Map<String, Map<ClassLoader, Object>> singletonMap = new HashMap<String, Map<ClassLoader, Object>>();
> to
> private static Map<ClassLoader, Map<String, Object>> singletonMap = new HashMap<ClassLoader, Map<String, Object>>();
> Currently, this only really breaks removeInstance(String name) which AFAICT has no callers.  This would be replaced by e.g.
> clearInstance(ClassLoader cl)
> And most current callers of clearInstances() would I think prefer to just clear an individual classloader.
> Opinions welcome, and curious if anyone wants to preserve a removeInstance(String name) method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OWB-357) WebbeansFinder should index first on ClassLoader, not singleton type

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OWB-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gurkan Erdogdu closed OWB-357.
------------------------------

      Assignee: Gurkan Erdogdu  (was: Eric Covener)
    Resolution: Fixed

Done.

> WebbeansFinder should index first on ClassLoader, not singleton type
> --------------------------------------------------------------------
>
>                 Key: OWB-357
>                 URL: https://issues.apache.org/jira/browse/OWB-357
>             Project: OpenWebBeans
>          Issue Type: Bug
>    Affects Versions: M4
>         Environment: tiered classloader
>            Reporter: Eric Covener
>            Assignee: Gurkan Erdogdu
>            Priority: Minor
>             Fix For: 1.0.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> I'm finding WebbeansFinder a little difficult  to work with since it is unable to easily clear all instances a / the current classloader.
> I would like to change the map to have the primary index on the classloader from:
> private static Map<String, Map<ClassLoader, Object>> singletonMap = new HashMap<String, Map<ClassLoader, Object>>();
> to
> private static Map<ClassLoader, Map<String, Object>> singletonMap = new HashMap<ClassLoader, Map<String, Object>>();
> Currently, this only really breaks removeInstance(String name) which AFAICT has no callers.  This would be replaced by e.g.
> clearInstance(ClassLoader cl)
> And most current callers of clearInstances() would I think prefer to just clear an individual classloader.
> Opinions welcome, and curious if anyone wants to preserve a removeInstance(String name) method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.