You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/18 16:55:00 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3586: NO-JIRA Fix maven compiler version for java 1.8
brusdev opened a new pull request #3586:
URL: https://github.com/apache/activemq-artemis/pull/3586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3586: NO-JIRA Fix maven compiler version for java 1.8
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3586:
URL: https://github.com/apache/activemq-artemis/pull/3586#issuecomment-843379434
Can you elaborate what is 'broken', is it just that '8 != 1.8'? As I understood when Emmanuel made the change, the compiler plugin understands the '8' and so it works. I'd expect it would fail before now otherwise since its been like this for around a year now.
If there is a real issue it probably warrants a JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3586: NO-JIRA Fix maven compiler version for java 1.8
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3586:
URL: https://github.com/apache/activemq-artemis/pull/3586#issuecomment-843399276
I should note I'm not against changing this, I use the original '1.8' style syntax elsewhere, its just '8' isnt really wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3586: NO-JIRA Fix maven compiler version for java 1.8
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3586:
URL: https://github.com/apache/activemq-artemis/pull/3586#issuecomment-844146568
Other poms could use the maven compiler version as default value for other purposes ie the enforcer `requireJavaVersion` rule. While the maven-compiler-plugin supports both `1.8` and `8` values, other plugin as `maven-enforcer-plugin` supports just the `1.8` value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3586: NO-JIRA Fix maven compiler version for java 1.8
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3586:
URL: https://github.com/apache/activemq-artemis/pull/3586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org