[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2414: fix several races in stream load that could cause BE crash

[GitBox <gi...@apache.org>]

gaodayue commented on a change in pull request #2414: fix several races in stream load that could cause BE crash
URL: https://github.com/apache/incubator-doris/pull/2414#discussion_r355810804
 
 

 ##########
 File path: be/src/runtime/load_channel_mgr.cpp
 ##########
 @@ -135,11 +135,15 @@ Status LoadChannelMgr::add_batch(
 
     // 4. handle finish
     if (channel->is_finished()) {
-        std::lock_guard<std::mutex> l(_lock);
-        _load_channels.erase(load_id);
-        auto handle = _lastest_success_channel->insert(
+        LOG(INFO) << "removing load channel " << load_id << " because it's finished";
+        {
+            std::lock_guard<std::mutex> l(_lock);
+            _load_channels.erase(load_id);
+            auto handle = _lastest_success_channel->insert(
                 load_id.to_string(), nullptr, 1, dummy_deleter);
-        _lastest_success_channel->release(handle);
+            _lastest_success_channel->release(handle);
+        }
+        LOG(INFO) << "removed load channel " << load_id;
 
 Review comment:
   OK, I'll change the second log to VLOG

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org