[jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224629#comment-16224629 ] 

ASF GitHub Bot commented on THRIFT-4378:
----------------------------------------

GitHub user itegel opened a pull request:

    https://github.com/apache/thrift/pull/1408

    THRIFT-4378: add stopTimeoutUnit set method

    add set method for stopTimeoutUnit to TThreadPoolServer, in java lib

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/itegel/thrift THRIFT-4378

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1408
    
----
commit 4f105b3ba2ef06558c8f898eccb467af50668d09
Author: baoxiangxin <ba...@didichuxing.com>
Date:   2017-10-30T10:21:21Z

    add stopTimeoutUnit set method

----


> add set stopTimeoutUnit method to TThreadPoolServer
> ---------------------------------------------------
>
>                 Key: THRIFT-4378
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4378
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>         Environment: java lib
>            Reporter: itegel bao
>            Priority: Minor
>
> All time units all have set method, except this stopTimeoutUnit, in TThreadPoolServer. 
> And for default it is se to TimeUnit.SECONDS. 
> In our projects we prefer TimeUnit.MILLISECONDS to TimeUnit.SECONDS, at least we want it to be the same over whole project.
> So can we add a set methods for stopTimeoutUnit



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)