You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@omid.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2018/08/19 05:20:00 UTC

[jira] [Comment Edited] (OMID-107) Replace HTableInterface with Table

    [ https://issues.apache.org/jira/browse/OMID-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585016#comment-16585016 ] 

James Taylor edited comment on OMID-107 at 8/19/18 5:19 AM:
------------------------------------------------------------

[~ohads] - would you mind reviewing this patch? I still get one failure, and I'm not sure why.
{code:java}
Running TestSuite

Tests run: 91, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 606.813 sec <<< FAILURE! - in TestSuite

testSIPreventsReadSkewUsingWritePredicate(org.apache.omid.transaction.TestBaillisAnomaliesWithTXs)  Time elapsed: 0.101 sec  <<< FAILURE!

java.lang.AssertionError: Should be aborted

at org.apache.omid.transaction.TestBaillisAnomaliesWithTXs.testSIPreventsReadSkewUsingWritePredicate(TestBaillisAnomaliesWithTXs.java:416)

{code}
I don't really understand the test. Why should the transaction fail?


was (Author: jamestaylor):
[~ohads] - would you mind reviewing this patch? I still get one failure, and I'm not sure why.
{code:java}
Running TestSuite

Tests run: 91, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 606.813 sec <<< FAILURE! - in TestSuite

testSIPreventsReadSkewUsingWritePredicate(org.apache.omid.transaction.TestBaillisAnomaliesWithTXs)  Time elapsed: 0.101 sec  <<< FAILURE!

java.lang.AssertionError: Should be aborted

at org.apache.omid.transaction.TestBaillisAnomaliesWithTXs.testSIPreventsReadSkewUsingWritePredicate(TestBaillisAnomaliesWithTXs.java:416)

{code}

> Replace HTableInterface with Table
> ----------------------------------
>
>                 Key: OMID-107
>                 URL: https://issues.apache.org/jira/browse/OMID-107
>             Project: Apache Omid
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Priority: Major
>         Attachments: OMID-107.patch
>
>
> In HBase 2.0, the HTableInterface has been replaced with the Table interface. Thus, in Omid, this same replacement should take place. This will mostly be isolated to having TTable implement Table instead of HTableInterface. This will be required to check-in Omid support in Phoenix, since Phoenix 5.x is based on HBase 2.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)