[GitHub] [solr] stillalex commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

[GitBox <gi...@apache.org>]

stillalex commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1039797943


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -88,23 +89,63 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, String... baseSolrUrls) {
     this.httpClient = httpClient;
   }
 
+  public LBHttp2SolrClient(Http2SolrClient httpClient, List<String> baseSolrUrls, Builder builder) {

Review Comment:
   should this be 'protected' instead of 'public'?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org