You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2022/08/24 09:39:49 UTC
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18898
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
IMPALA-11496: Push down date literals to Kudu scanner
This change enables creating, and pushing down Kudu
predicates from DATE type. Kudu planner testcases
added for DATE, BIGINT, FLOAT,DOUBLE types to
cover all supported type's predicate creation.
Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
2 files changed, 76 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/18898/2
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18898
to look at the new patch set (#3).
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
IMPALA-11496: Push down date literals to Kudu scanner
This change enables creating, and pushing down Kudu
predicates from DATE type. Kudu planner testcases
added for DATE, BIGINT, FLOAT, DOUBLE types to
cover all supported type's predicate creation.
Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
2 files changed, 76 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/18898/3
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@571
PS2, Line 571: kuduPredicate = KuduPredicate.newComparisonPredicate(column, op, ((DateLiteral)literal).getValue());
line too long (108 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 09:40:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11218/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 13:11:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18898
to look at the new patch set (#4).
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
IMPALA-11496: Push down date literals to Kudu scanner
This change enables creating, and pushing down Kudu
predicates from DATE type. Kudu planner testcases
added for DATE, BIGINT, FLOAT, DOUBLE types to
cover all supported type's predicate creation.
Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
2 files changed, 77 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/18898/4
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18898/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18898/2//COMMIT_MSG@11
PS2, Line 11: added for DATE, BIGINT, FLOAT, DOUBLE types to
> nit: extra space
Done
http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@571
PS2, Line 571: kuduPredicate = KuduPredicate.newComparisonPredicate(column, op,
> line too long (108 > 90)
Done
http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@580
PS2, Line 580: //All supported types are covered
> We generally use Preconditions.checkState(false)
Done
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 12:59:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8508/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 04:24:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 13:56:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has removed a vote on this change.
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
IMPALA-11496: Push down date literals to Kudu scanner
This change enables creating, and pushing down Kudu
predicates from DATE type. Kudu planner testcases
added for DATE, BIGINT, FLOAT, DOUBLE types to
cover all supported type's predicate creation.
Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Reviewed-on: http://gerrit.cloudera.org:8080/18898
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test
2 files changed, 77 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 17:43:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8505/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 17:44:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11241/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 16:21:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18898/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18898/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@583
PS3, Line 583:
> You could add a preconditions check here:
Done
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 16:02:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 5:
The failure looks unrelated, rerunning the tests
19:48:06 docker: Error response from daemon: Get https://registry-1.docker.io/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers).
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 04:23:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8505/
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 22:28:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 09:07:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 17:44:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11217/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 10:00:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11496: Push down date literals to Kudu scanner
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Thanks, LGTM.
http://gerrit.cloudera.org:8080/#/c/18898/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18898/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@583
PS3, Line 583:
You could add a preconditions check here:
Preconditions.checkState(kuduPredicate != null);
--
To view, visit http://gerrit.cloudera.org:8080/18898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e
Gerrit-Change-Number: 18898
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 14:34:56 +0000
Gerrit-HasComments: Yes