You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/05 14:58:32 UTC

[GitHub] [pulsar] AnonHxy opened a new pull request, #15941: [fix][broker]Fix topic policies update not check message expiry

AnonHxy opened a new pull request, #15941:
URL: https://github.com/apache/pulsar/pull/15941

   ### Motivation
   
   We need check message expiry when topic-level policies updated,  just like when namespace-level updated, line: 2399
   https://github.com/apache/pulsar/blob/91cb00eab0fbbc0d519f5ad1ac8ab722da56b349/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2366-L2399
   
   ### Modifications
   
   Invoke `checkMessageExpiry()` when topic-level policies updated.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
     
   - [x] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on code in PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#discussion_r894983469


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -3026,7 +3026,7 @@ public void onUpdate(TopicPolicies policies) {
             updateSubscribeRateLimiter();
             replicators.forEach((name, replicator) -> replicator.getRateLimiter()
                     .ifPresent(DispatchRateLimiter::updateDispatchRate));
-
+            checkMessageExpiry();

Review Comment:
   Yes. I have added UT `testTTLPoliciesUpdate`. PTAL again @codelipenghui 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#issuecomment-1153058680

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 merged pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
Jason918 merged PR #15941:
URL: https://github.com/apache/pulsar/pull/15941


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#issuecomment-1147043731

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#issuecomment-1146962153

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#issuecomment-1152916328

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#discussion_r893578160


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -3026,7 +3026,7 @@ public void onUpdate(TopicPolicies policies) {
             updateSubscribeRateLimiter();
             replicators.forEach((name, replicator) -> replicator.getRateLimiter()
                     .ifPresent(DispatchRateLimiter::updateDispatchRate));
-
+            checkMessageExpiry();

Review Comment:
   Is it able to add a test to avoid regression?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#issuecomment-1153058688

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #15941: [fix][broker]Fix topic policies update not check message expiry

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #15941:
URL: https://github.com/apache/pulsar/pull/15941#issuecomment-1147085814

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org