You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alexandreyc (via GitHub)" <gi...@apache.org> on 2024/01/29 13:49:52 UTC
[PR] feat(rust): add driver manager and ability to expose Rust driver as C driver [arrow-adbc]
alexandreyc opened a new pull request, #1496:
URL: https://github.com/apache/arrow-adbc/pull/1496
Hello world!
Here is a PR that rebases the work done by @wjones127 in #446 and #416 to implement the driver manager and add the ability to expose native Rust driver as C API driver.
As of now, I've ensured that the code compiles, and the tests pass — excluding one, which I've temporarily ignored due to uncertainty about the logic. Additionally, I've made several minor improvements throughout.
I decided to remove async methods from core traits because, at this stage, it seemed to introduce unnecessary complexity without tangible benefits, especially since the C API is synchronous. Feel free to express your thoughts if you disagree :)
While the code has reached a functional state, I believe it could benefit from a thorough review, particularly in terms of memory and thread safety. I am currently integrating it with my application and anticipate uncovering any potential bugs (or confirming their absence).
I'm aware of the progress made by @mbrobbel in issue #1326, but I find it more reasonable to merge this PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): add driver manager and ability to expose Rust driver as C driver [arrow-adbc]
Posted by "alexandreyc (via GitHub)" <gi...@apache.org>.
alexandreyc commented on PR #1496:
URL: https://github.com/apache/arrow-adbc/pull/1496#issuecomment-2059087047
Close in favor of #1725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): add driver manager and ability to expose Rust driver as C driver [arrow-adbc]
Posted by "alexandreyc (via GitHub)" <gi...@apache.org>.
alexandreyc closed pull request #1496: feat(rust): add driver manager and ability to expose Rust driver as C driver
URL: https://github.com/apache/arrow-adbc/pull/1496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org