You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 11:35:10 UTC

[GitHub] [airflow] rajaths010494 commented on a diff in pull request #25302: Dataproc submit job operator async

rajaths010494 commented on code in PR #25302:
URL: https://github.com/apache/airflow/pull/25302#discussion_r934429065


##########
airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -958,6 +962,19 @@ def execute(self, context: 'Context'):
                 context=context, task_instance=self, url=DATAPROC_JOB_LOG_LINK, resource=job_id
             )
 
+            if self.deferrable:
+                self.defer(
+                    trigger=DataprocBaseTrigger(
+                        job_id=self.job_id,
+                        project_id=self.project_id,
+                        region=self.region,
+                        delegate_to=self.delegate_to,
+                        gcp_conn_id=self.gcp_conn_id,
+                        impersonation_chain=self.impersonation_chain,
+                        pooling_period_seconds=10,

Review Comment:
   can we not hardcode this value and use it as a param taken from the user as `polling_interval`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org