[GitHub] [arrow-datafusion] andygrove opened a new issue, #2536: Move `LogicalPlanBuilder` to `datafusion-expr` crate

[GitBox <gi...@apache.org>]

andygrove opened a new issue, #2536:
URL: https://github.com/apache/arrow-datafusion/issues/2536

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   There are various reasons why I would like `LogicalPlanBuilder` to move to the same crate as `LogicalPlan`:
   - It would solve a major barrier to moving the SQL query planner into its own crate (https://github.com/apache/arrow-datafusion/issues/2345)
   - It would allow us to fix https://github.com/apache/arrow-datafusion/issues/2308 and re-enable rustdoc testing of the documentation for the logical plan
   - Non-technical reason but It just seems natural for `LogicalPlan` and `LogicalPlanBuilder` to be in the same crate
   
   The reason we can't just move `LogicalPlanBuilder` in its current state is that the `scan_*` methods depend on the `datasource` module from the core crate (which in turn depend on the physical plan). Given that these methods are mostly just called from the execution context, I propose that we move the logic fully into the execution context and then just call a version of `LogicalPlanBuilder::scan` that accepts a `TableSource` instead.
   
   **Describe the solution you'd like**
   See above.
   
   **Describe alternatives you've considered**
   None
   
   **Additional context**
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove closed issue #2536: Move `LogicalPlanBuilder` to `datafusion-expr` crate

[GitBox <gi...@apache.org>]

andygrove closed issue #2536: Move `LogicalPlanBuilder` to `datafusion-expr` crate
URL: https://github.com/apache/arrow-datafusion/issues/2536


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org