You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Chris Geer <ch...@cxtsoftware.com> on 2012/03/06 18:15:36 UTC
Re: Review Request: Fixed missing javax.mail dependency and got project to
compile.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4192/
-----------------------------------------------------------
(Updated 2012-03-06 17:15:36.429202)
Review request for rave and Raminder Singh.
Summary
-------
I'm new to Rave and have been trying to get the vanilla portal up and running and was hung up on this issue. Attached is my patch to get things working better. It fixes this issue by adding the javax.mail dependency to the portal, fixes an issue where the DefaultUserService constructor has changed and updated the poms to map to version 0.10-SNAPSHOT.
If we need to split the patch and create some other JIRA issues please let me know.
This addresses bug RAVE-488.
https://issues.apache.org/jira/browse/RAVE-488
Diffs
-----
/sandbox/rave-extensions/rave-vanilla-extension/pom.xml 1297337
/sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/pom.xml 1297337
/sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/main/java/org/apache/rave/portal/service/impl/CustomUserService.java 1297337
/sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/test/java/org/apache/rave/portal/service/impl/CustomUserServiceTest.java 1297337
/sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-shindig/pom.xml 1297337
Diff: https://reviews.apache.org/r/4192/diff
Testing
-------
Project will compile and deploy. There is still an error when navigating to the site because there is no login.jsp at the moment.
Thanks,
Chris
Re: Review Request: Fixed missing javax.mail dependency and got project to
compile.
Posted by Raminder Singh <ra...@apache.org>.
> On 2012-03-06 17:43:13, Raminder Singh wrote:
> >
i am facing the same problem and i think i know the problem. Login.jsp is exclude in project pom and rave extension used to have its own login,jsp which is missing.
- Raminder
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4192/#review5647
-----------------------------------------------------------
On 2012-03-06 17:15:36, Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4192/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 17:15:36)
>
>
> Review request for rave and Raminder Singh.
>
>
> Summary
> -------
>
> I'm new to Rave and have been trying to get the vanilla portal up and running and was hung up on this issue. Attached is my patch to get things working better. It fixes this issue by adding the javax.mail dependency to the portal, fixes an issue where the DefaultUserService constructor has changed and updated the poms to map to version 0.10-SNAPSHOT.
>
> If we need to split the patch and create some other JIRA issues please let me know.
>
>
> This addresses bug RAVE-488.
> https://issues.apache.org/jira/browse/RAVE-488
>
>
> Diffs
> -----
>
> /sandbox/rave-extensions/rave-vanilla-extension/pom.xml 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/pom.xml 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/main/java/org/apache/rave/portal/service/impl/CustomUserService.java 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/test/java/org/apache/rave/portal/service/impl/CustomUserServiceTest.java 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-shindig/pom.xml 1297337
>
> Diff: https://reviews.apache.org/r/4192/diff
>
>
> Testing
> -------
>
> Project will compile and deploy. There is still an error when navigating to the site because there is no login.jsp at the moment.
>
>
> Thanks,
>
> Chris
>
>
Re: Review Request: Fixed missing javax.mail dependency and got project to
compile.
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4192/#review5647
-----------------------------------------------------------
- Raminder
On 2012-03-06 17:15:36, Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4192/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 17:15:36)
>
>
> Review request for rave and Raminder Singh.
>
>
> Summary
> -------
>
> I'm new to Rave and have been trying to get the vanilla portal up and running and was hung up on this issue. Attached is my patch to get things working better. It fixes this issue by adding the javax.mail dependency to the portal, fixes an issue where the DefaultUserService constructor has changed and updated the poms to map to version 0.10-SNAPSHOT.
>
> If we need to split the patch and create some other JIRA issues please let me know.
>
>
> This addresses bug RAVE-488.
> https://issues.apache.org/jira/browse/RAVE-488
>
>
> Diffs
> -----
>
> /sandbox/rave-extensions/rave-vanilla-extension/pom.xml 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/pom.xml 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/main/java/org/apache/rave/portal/service/impl/CustomUserService.java 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/test/java/org/apache/rave/portal/service/impl/CustomUserServiceTest.java 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-shindig/pom.xml 1297337
>
> Diff: https://reviews.apache.org/r/4192/diff
>
>
> Testing
> -------
>
> Project will compile and deploy. There is still an error when navigating to the site because there is no login.jsp at the moment.
>
>
> Thanks,
>
> Chris
>
>
Re: Review Request: Fixed missing javax.mail dependency and got project to
compile.
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4192/#review5649
-----------------------------------------------------------
Ship it!
Looks like there are more problems after i fixed rave-vanilla-extension-portal pom to not exclude the login.jsp. i got java.lang.IllegalStateException: No registered metadata for type "class org.apache.rave.portal.model.NewCustomUser". This can happen if this class has not been annotated as a persistent entity or specified in the persistence unit (ex: in the orm.xml). error. This can be fixed by removing NewCustomUser class. I am going to commit your changes as they are good to fix other problem and will handle extending user object in a different ticket.
- Raminder
On 2012-03-06 17:15:36, Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4192/
> -----------------------------------------------------------
>
> (Updated 2012-03-06 17:15:36)
>
>
> Review request for rave and Raminder Singh.
>
>
> Summary
> -------
>
> I'm new to Rave and have been trying to get the vanilla portal up and running and was hung up on this issue. Attached is my patch to get things working better. It fixes this issue by adding the javax.mail dependency to the portal, fixes an issue where the DefaultUserService constructor has changed and updated the poms to map to version 0.10-SNAPSHOT.
>
> If we need to split the patch and create some other JIRA issues please let me know.
>
>
> This addresses bug RAVE-488.
> https://issues.apache.org/jira/browse/RAVE-488
>
>
> Diffs
> -----
>
> /sandbox/rave-extensions/rave-vanilla-extension/pom.xml 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/pom.xml 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/main/java/org/apache/rave/portal/service/impl/CustomUserService.java 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-portal/src/test/java/org/apache/rave/portal/service/impl/CustomUserServiceTest.java 1297337
> /sandbox/rave-extensions/rave-vanilla-extension/rave-vanilla-extension-shindig/pom.xml 1297337
>
> Diff: https://reviews.apache.org/r/4192/diff
>
>
> Testing
> -------
>
> Project will compile and deploy. There is still an error when navigating to the site because there is no login.jsp at the moment.
>
>
> Thanks,
>
> Chris
>
>