[GitHub] syed commented on a change in pull request #2253: [Managed Storage] When starting a VM, make sure it has the correct volume access group

[gi...@git.apache.org]

syed commented on a change in pull request #2253: [Managed Storage] When starting a VM, make sure it has the correct volume access group
URL: https://github.com/apache/cloudstack/pull/2253#discussion_r136186503
 
 

 ##########
 File path: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ##########
 @@ -1369,6 +1369,13 @@ public void prepare(VirtualMachineProfile vm, DeployDestination dest) throws Sto
             if (task.type == VolumeTaskType.NOP) {
                 pool = (StoragePool)dataStoreMgr.getDataStore(task.pool.getId(), DataStoreRole.Primary);
                 vol = task.volume;
+                if (pool.isManaged()) {
 
 Review comment:
   I think you are right @mike-tutkowski It definitely simplifies things.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services