[jira] Commented: (DDLUTILS-168) DatabaseTaskBase should keep log4j configuration untouched

["Philippe de M. Sevestre (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DDLUTILS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487765 ] 

Philippe de M. Sevestre commented on DDLUTILS-168:
--------------------------------------------------

Hi,

Thanks for your quick answer.

I won't question the resolution outcome - it's your call afterall - but I'd like to make some comments on the last two of the given reasons:

* Yes, there are issues with JBoss + commons-logging. JBoss uses it internally so it is usually considerered a no-no including it with your app. You can, of course, use it freely and - which is a great advantage, IMO - manage all log categories from all apps from a single configuration file and/or via its jmx console.

* I think I didn't make myself clear on the tasks usage subject. In my particular case, I use ant as a driver for some ETL jobs. In this scenario, ddlutils' tasks are only a step inside an ant script, and it makes more sense to keep all the steps in a standard build.xml file than configuring and calling each task directly from my code. Since ant also have some wrappers, calling it, passing a build script as an argument, is no big deal and makes maintenance easier.

Anyway, the changed code works fine in JBoss now.

Regards,

Philippe.

> DatabaseTaskBase should keep log4j configuration untouched
> ----------------------------------------------------------
>
>                 Key: DDLUTILS-168
>                 URL: https://issues.apache.org/jira/browse/DDLUTILS-168
>             Project: DdlUtils
>          Issue Type: Improvement
>          Components: Ant Tasks
>         Environment: all
>            Reporter: Philippe de M. Sevestre
>         Assigned To: Thomas Dudziak
>            Priority: Minor
>
> DatabaseTaskBase should hava an option to keep log4j´s configuration untouched. In current version, the implemented behaviour causes conflicts when running ant via its API from, say, a jmx inside JBoss. 
> The symptom is the infamous log4j´s  message "ERROR: invalid console appender config detected, console stream is looping".
> In my private copy of ddlutils, I´ve implemented a workaround by surrounding most of  the code inside the function initLogging() with an "if (  a sensible system property not found ) {  do log4j stuff }".
> Actually, I don´t know why is this code there, anyway... The comment in the code say that you´re forcing console output, but makes no mention about the reasoning behind this decision.
> Should´t log be simply delegated to commons-logging ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.