[GitHub] [curator] kezhuw commented on pull request #471: CURATOR-682: Use Gradle Enterprise Maven Extension to normalize Bnd-LastModified

["kezhuw (via GitHub)" <gi...@apache.org>]

kezhuw commented on PR #471:
URL: https://github.com/apache/curator/pull/471#issuecomment-1667540915

   > The Gradle Enterprise Maven Extension offers the ability to cache the results of surefire tests. When the timestamp value of "Bnd-LastModified" is changing on every build, the cache is invalidated and a cache hit never occurs for these expensive tests.
   
   > On master, the experiment will show a cache miss. With this change, the experiment will show a cache hit.
   
   Might be stupid, but I am lost in verify this. Are we going to "cache the results of surefire tests" ?
   
   I think when we run tests, we are also test for concurrency and randomness or even flaky tests. Basically, I don't think we should do that if it is the intend.
   
   For normal classes, I saw "Loaded from the build cache" in e44115e2fb5ea77af1bfe825ce122caf59e53fc1, which is `HEAD^` of this pr, with clean "~/.m2/.gradle-enterprise/build-cache/v1/" directory and "mvn clean package -DskipTests",  "mvn clean verify" in order.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org