You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/10 20:56:35 UTC
[GitHub] [airflow] pdeardorff-r7 commented on a change in pull request
#6007: [AIRFLOW-2310] Enable AWS Glue Job Integration
pdeardorff-r7 commented on a change in pull request #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration
URL: https://github.com/apache/airflow/pull/6007#discussion_r406940636
##########
File path: airflow/providers/amazon/aws/hooks/glue.py
##########
@@ -0,0 +1,172 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.exceptions import AirflowException
+from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook
+import time
+
+
+class AwsGlueJobHook(AwsBaseHook):
+ """
+ Interact with AWS Glue - create job, trigger, crawler
+
+ :param job_name: unique job name per AWS account
+ :type job_name: Optional[str]
+ :param desc: job description
+ :type desc: Optional[str]
+ :param concurrent_run_limit: The maximum number of concurrent runs allowed for a job
+ :type concurrent_run_limit: int
+ :param script_location: path to etl script either on s3 or local
+ :type script_location: Optional[str]
+ :param retry_limit: Maximum number of times to retry this job if it fails
+ :type retry_limit: int
+ :param num_of_dpus: Number of AWS Glue DPUs to allocate to this Job
+ :type num_of_dpus: int
+ :param region_name: aws region name (example: us-east-1)
+ :type region_name: Optional[str]
+ :param iam_role_name: AWS IAM Role for Glue Job
+ :type iam_role_name: Optional[str]
+ :param s3_bucket: S3 bucket where logs and local etl script will be uploaded
+ :type s3_bucket: Optional[str]
+ """
+ JOB_POLL_INTERVAL = 6 # polls job status after every JOB_POLL_INTERVAL seconds
+
+ def __init__(self,
+ job_name=None,
+ desc=None,
+ concurrent_run_limit=1,
+ script_location=None,
+ retry_limit=0,
+ num_of_dpus=10,
+ region_name=None,
+ iam_role_name=None,
+ s3_bucket, *args, **kwargs):
+ self.job_name = job_name
+ self.desc = desc
+ self.concurrent_run_limit = concurrent_run_limit
+ self.script_location = script_location
+ self.retry_limit = retry_limit
+ self.num_of_dpus = num_of_dpus
+ self.region_name = region_name
+ self.s3_bucket = s3_bucket
+ self.role_name = iam_role_name
+ self.S3_GLUE_LOGS = 'logs/glue-logs/'
+ super(AwsGlueJobHook, self).__init__(*args, **kwargs)
+
+ def get_conn(self):
+ conn = self.get_client_type('glue', self.region_name)
+ return conn
+
+ def list_jobs(self):
+ conn = self.get_conn()
+ return conn.get_jobs()
+
+ def get_iam_execution_role(self):
+ """
+ :return: iam role for job execution
+ """
+ iam_client = self.get_client_type('iam', self.region_name)
+
+ try:
+ glue_execution_role = iam_client.get_role(RoleName=self.role_name)
+ self.log.info("Iam Role Name: %s", self.role_name)
+ return glue_execution_role
+ except Exception as general_error:
+ self.log.error(f'Failed to create aws glue job, error: {str(general_error)}')
+ raise
+
+ def initialize_job(self, script_arguments=None):
+ """
+ Initializes connection with AWS Glue
+ to run job
+ :return:
+ """
+ if self.s3_bucket is None:
+ raise AirflowException(
+ 'Could not initialize glue job, '
+ 'error: Specify Parameter `s3_bucket`'
+ )
+
+ glue_client = self.get_conn()
+
+ try:
+ job_name = self.get_or_create_glue_job()
+ job_run = glue_client.start_job_run(
+ JobName=job_name,
+ Arguments=script_arguments
+ )
+ return self.job_completion(job_name, job_run['JobRunId'])
+ except Exception as general_error:
+ self.log.error(f'Failed to run aws glue job, error: {str(general_error)}')
+ raise
+
+ def job_completion(self, job_name=None, run_id=None):
+ """
+ :param job_name: unique job name per AWS account
+ :type job_name: str
+ :param run_id: The job-run ID of the predecessor job run
+ :type run_id: str
+ :return:
+ """
+ while True:
+ glue_client = self.get_conn()
+ job_status = glue_client.get_job_run(
+ JobName=job_name,
+ RunId=run_id,
+ PredecessorsIncluded=True
+ )
+ job_run_state = job_status['JobRun']['JobRunState']
+ done_states = ['FAILED', 'STOPPED', 'SUCCEEDED']
+ if job_run_state in done_states:
+ self.log.info("Exiting Job %s Run State: %s", run_id, job_run_state)
+ return {'JobRunState': job_run_state, 'JobRunId': run_id}
+ else:
+ self.log.info("Polling for AWS Glue Job %s current run state with status %s"
+ , job_name, job_run_state)
+ time.sleep(self.JOB_POLL_INTERVAL)
+
+ def get_or_create_glue_job(self):
+ """
+ Creates(or just returns) and returns the Job name
+ :return:Name of the Job
+ """
+ glue_client = self.get_conn()
+ try:
+ get_job_response = glue_client.get_job(JobName=self.job_name)
+ self.log.info("Job Already exist. Returning Name of the job")
+ return get_job_response['Job']['Name']
+ except glue_client.exceptions.EntityNotFoundException:
+ self.log.info("Job doesnt exist. Now creating and running AWS Glue Job")
+ s3_log_path = f's3://{str(self.s3_bucket)}/{str(self.S3_GLUE_LOGS)}{str(self.job_name)}'
+ execution_role = self.get_iam_execution_role()
+ try:
+ create_job_response = glue_client.create_job(
+ Name=self.job_name,
+ Description=self.desc,
+ LogUri=s3_log_path,
+ Role=execution_role['Role']['RoleName'],
+ ExecutionProperty={"MaxConcurrentRuns": self.concurrent_run_limit},
+ Command={"Name": "glueetl", "ScriptLocation": self.script_location},
+ MaxRetries=self.retry_limit,
+ AllocatedCapacity=self.num_of_dpus
+ )
+ return create_job_response['Name']
+ except Exception as general_error:
+ self.log.error(f'Failed to create aws glue job, error: {str(general_error)}')
Review comment:
python is expecting an indent here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services