You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/09 03:35:15 UTC
[GitHub] [incubator-doris] vagetablechicken opened a new issue #3282:
Opening data dirs parallelly is not thread-safe
vagetablechicken opened a new issue #3282: Opening data dirs parallelly is not thread-safe
URL: https://github.com/apache/incubator-doris/issues/3282
**Describe the bug**
162b1c5d8bfd8afb7b01951ea5c5a79d1ffe1679 makes the data dirs init parallelly, but I found it's not thread-safe.
When be is starting, it may get this error:
```
[data_dir.cpp:249] fail to find file system, path=/xxx
```
I didn't notice that `DataDir::_init_file_system()` may have race conditions.
`getmntent()` value is `MT-Unsafe race:mntentbuf locale`
We have two solutions:
1. use `getmntent_r()` instread, `getmntent_r()` value is MT-Safe locale.
1. split `_init_meta()`(open rocksdb), just `_init_meta()` in parallel. Keep other parts of data dir init in sequential order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay closed issue #3282: Opening data dirs
parallelly is not thread-safe
Posted by GitBox <gi...@apache.org>.
imay closed issue #3282: Opening data dirs parallelly is not thread-safe
URL: https://github.com/apache/incubator-doris/issues/3282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on issue #3282: Opening data dirs
parallelly is not thread-safe
Posted by GitBox <gi...@apache.org>.
imay commented on issue #3282: Opening data dirs parallelly is not thread-safe
URL: https://github.com/apache/incubator-doris/issues/3282#issuecomment-611314836
I prefer option 1, it seems simple. Because the master branch has bug, hope that you can fix it ASAP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] vagetablechicken commented on issue #3282:
Opening data dirs parallelly is not thread-safe
Posted by GitBox <gi...@apache.org>.
vagetablechicken commented on issue #3282: Opening data dirs parallelly is not thread-safe
URL: https://github.com/apache/incubator-doris/issues/3282#issuecomment-611315512
> I prefer option 1, it seems simple. Because the master branch has bug, hope that you can fix it ASAP.
OK, it is my primary task today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org