[GitHub] [superset] rusackas commented on a diff in pull request #21479: chore: adding missing translation function

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #21479:
URL: https://github.com/apache/superset/pull/21479#discussion_r1043856193


##########
superset-frontend/src/components/ListView/Filters/DateRange.tsx:
##########
@@ -62,7 +62,7 @@ function DateRangeFilter(
 
   return (
     <RangeFilterContainer>
-      <FormLabel>{Header}</FormLabel>
+      <FormLabel>{t(Header as string)}</FormLabel>

Review Comment:
   Can you explain the "as string" need here? If this is a dynamic value, it might not be wise to use the t() here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org