You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by MatthewBooth <gi...@git.apache.org> on 2016/02/19 18:19:06 UTC
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
GitHub user MatthewBooth opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/174
Rebased ochakov's branch to the latest as of writing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MatthewBooth/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit 91dd693623ae17c84d5d8e3e27139247b2b59690
Author: ochakov <ev...@ochakov.com>
Date: 2015-12-01T21:10:43Z
Fix missing CAMERA permission for Android M
Fixing a bug where for Android M new permissions model, only external storage permission was asked, while camera permission was not, causing camera to fail on Android 6.0
commit 70fcf30423946ec9d3299be1495ddd44cacff3c1
Author: ochakov <ev...@ochakov.com>
Date: 2015-12-01T21:34:08Z
Fix requiring both Camera and Storage permissions
To take a picture on Android M, both Camera and Storage access permissions are required. Now asking for both permissions simultaneously.
commit c4618a894eec92349371221fe18b5572151bff6f
Author: ochakov <ev...@ochakov.com>
Date: 2015-12-02T23:51:22Z
Check android.permission.CAMERA in the package
According to the PR conversation, when android.permission.CAMERA is not set in the package, there is no need to ask for the camera permission. Also, checking now camera and storage permissions separately, so if only one of them is missing, the other one will be requested and not both.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-188971773
Rebased and updated in #179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186937961
There was an issue on JIRA about the camera permission and was closed as "won't fix" becase camera permission shouldn't be asked by the app as we use an intent and according to the docs, it isn't needed. I don't remember the issue number right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-190839346
@MatthewBooth can you fill out an ICLA? I need that in order to merge your rebase. Instructions are here: http://cordova.apache.org/contribute/contribute_guidelines.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-188555220
I'm going to merge my branch tomorrow. @MatthewBooth can you close this PR and I'll open another?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-187097076
After reading the conversation on https://github.com/apache/cordova-plugin-camera/pull/142 this makes sense.
@riknoll if the PermissionHelper class should be used instead of the cordova methods, then I assume the documentation here is wrong https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html#android-permissions-cordova-android-5.0.x-and-greater
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by MatthewBooth <gi...@git.apache.org>.
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186313033
This is in response to @infil00p's comments here: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-186300094
I've tested in my project and this works as expected, both file permissions and camera permissions are requested and fufilled as necessary. Good work @ochakov.
I honestly don't know the codebase that well so you guys will want to check it, but it looks legit, and builds fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by MatthewBooth <gi...@git.apache.org>.
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-195320677
@riknoll Cheers, I've done that. Sent the ICLA signed with my GPG keys to the secretary, and signed up to JIRA.
I only rebased @ochakov's work, though, so there is no original code of mine in this. So feel free to merge with his permissions :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by MatthewBooth <gi...@git.apache.org>.
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186934876
Probably why Travis is failing. Beyond me, though. I prefer native Java to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-187320786
I also had some other comments on the old PR on the use of constants in the calls to requestPermission that didn't make it in. @MatthewBooth can you take a look? If not, I can do the fixes and add a commit. Once those changes are in I can test this PR and see about merging if everything checks out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by MatthewBooth <gi...@git.apache.org>.
Github user MatthewBooth commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-196224537
```Dear Matt Booth,
This message acknowledges receipt of your ICLA, which has been filed in the Apache Software Foundation records.
If you have been invited as a committer, please advise the project PMC that your ICLA has been filed.
Warm Regards,
-- Craig L Russell
Secretary, Apache Software Foundation ```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-186325651
This needs to use the new PermissionHelper class instead of the CordovaInterface methods for requestPermission and hasPermission
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-187278641
@jcesarmobile PermissionHelper is just for the core plugins and is a temporary measure. See this thread: http://markmail.org/message/bwhpuh7m6fyf5eem
The Travis test has been failing for a bit (I'm pretty sure that this PR is not causing it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-188500100
Alright, I pushed an update branch here: https://github.com/MSOpenTech/cordova-plugin-camera/tree/CB-10120. I still need to do some testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org