[GitHub] [ozone] sodonnel commented on a diff in pull request #3391: HDDS-6710. EC: Add EC pipeline limit to SCMConfigKeys and MiniOzoneCluster

[GitBox <gi...@apache.org>]

sodonnel commented on code in PR #3391:
URL: https://github.com/apache/ozone/pull/3391#discussion_r870144358


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableECContainerProvider.java:
##########
@@ -218,13 +218,14 @@ private long getConfiguredContainerSize() {
   @ConfigGroup(prefix = "ozone.scm.ec")
   public static class WritableECContainerProviderConfig {
 
-    @Config(key = "pipeline.minimum",
-        defaultValue = "5",
+    @Config(key = "pipeline.limit",

Review Comment:
   This parameter was not intended to be the limit, but the minimum number of pipelines we should have so we don't only have one pipeline and always allocate blocks to the same one.
   
   We need to finish off HDDS-5327 and decide on a strategy based on cluster size and load to determine the pipeline limit.
   
   As the code stands at the moment, this parameter indicates the number of pipelines that will end up open at any given time. It is like a minimum and a limit. Once we figure out how to handle the limit, then this parameter will be the minimum number of pipelines. Therefore it probably makes sense to keep the parameter named pipeline.minimum rathern than limit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org