You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/04 18:33:41 UTC
[GitHub] [airflow] dstandish opened a new pull request, #22734: KubernetesPodOperator should patch "already checked" always
dstandish opened a new pull request, #22734:
URL: https://github.com/apache/airflow/pull/22734
When not configured to delete pods, at end of task execution the current behavior is to patch the pod as "already checked", but only if pod not successful. We should also patch when successful so it isn't "reattached" to after a task clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #22734: KubernetesPodOperator should patch "already checked" always
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #22734:
URL: https://github.com/apache/airflow/pull/22734#issuecomment-1099680946
Looks good, but no unit test changes? Hmm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22734: KubernetesPodOperator should patch "already checked" always
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22734:
URL: https://github.com/apache/airflow/pull/22734#issuecomment-1100567837
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish merged pull request #22734: KubernetesPodOperator should patch "already checked" always
Posted by GitBox <gi...@apache.org>.
dstandish merged PR #22734:
URL: https://github.com/apache/airflow/pull/22734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22734: KubernetesPodOperator should patch "already checked" always
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #22734:
URL: https://github.com/apache/airflow/pull/22734#issuecomment-1100184252
updated unit tests to test for this directly. removed one test that was a duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22734: KubernetesPodOperator should patch "already checked" always
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #22734:
URL: https://github.com/apache/airflow/pull/22734#issuecomment-1099712125
> Looks good, but no unit test changes? Hmm.
Ah you mean as opposed to _integration_ tests? Sure I can add a unit test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org