You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DmytroShkvyra <gi...@git.apache.org> on 2017/02/17 10:15:26 UTC
[GitHub] zeppelin pull request #2032: [ZEPPELIN-791] add wildcards
GitHub user DmytroShkvyra opened a pull request:
https://github.com/apache/zeppelin/pull/2032
[ZEPPELIN-791] add wildcards
What is this PR for?
It is better have a single place where we manage project-wise RAT exclusions for a contributions under licenses different from Apache, then let maven sub-modules have them as we do now (makes things harder to track)
What type of PR is it?
[Improvement]
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-791
How should this be tested?
mvn verify -DskipTests
Screenshots (if appropriate)
Questions:
Does the licenses files need update? - No
Is there breaking changes for older versions? - No
Does this needs documentation? - No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DmytroShkvyra/zeppelin ZEPPELIN-791
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2032
----
commit 6146ed18abb9966b9134ebb5f568a110b76fb392
Author: DmytroShkvyra <ds...@gmail.com>
Date: 2017-02-17T09:54:30Z
[ZEPPELIN-791] add wildcards
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2032: [ZEPPELIN-791] Build infra: move all RAT to roo...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra closed the pull request at:
https://github.com/apache/zeppelin/pull/2032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2032: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/zeppelin/pull/2032
Seems to Jenkins does not work properly. See Travis results below:
https://travis-ci.org/DmytroShkvyra/zeppelin/builds/203390388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2032: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/zeppelin/pull/2032
Failed tests:
NotebookTest.testPublicPrivateNewNote:1173 expected:<2C9[FXZKX8]> but was:<2C9[4VAUTF]>
NotebookTest.testAuthorizationRoles:759 expected:<false> but was:<true>
@jongyoul , @felixcheung Thanks for review! I have resolved conflict but third party tests have been failed. It's pity that so simple PR couldn't be merged to master. Fix of these tests out of scope PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2032: [ZEPPELIN-791] Build infra: move all RAT to roo...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra closed the pull request at:
https://github.com/apache/zeppelin/pull/2032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2032: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2032
Sorry, it is hard that way. You could try again by closing and re-opening this PR...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2032: [ZEPPELIN-791] Build infra: move all RAT to roo...
Posted by DmytroShkvyra <gi...@git.apache.org>.
GitHub user DmytroShkvyra reopened a pull request:
https://github.com/apache/zeppelin/pull/2032
[ZEPPELIN-791] Build infra: move all RAT to root pom.xml
What is this PR for?
It is better have a single place where we manage project-wise RAT exclusions for a contributions under licenses different from Apache, then let maven sub-modules have them as we do now (makes things harder to track)
What type of PR is it?
[Improvement]
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-791
How should this be tested?
mvn verify -DskipTests
Screenshots (if appropriate)
Questions:
Does the licenses files need update? - No
Is there breaking changes for older versions? - No
Does this needs documentation? - No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DmytroShkvyra/zeppelin ZEPPELIN-791
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2032
----
commit c23cdf514b3ba1e4ef3748b64f991a8bbcb384d6
Author: DmytroShkvyra <ds...@gmail.com>
Date: 2017-02-23T10:50:41Z
[ZEPPELIN-791] fix conflict
commit a5fa056df9a305b42716f01b05f8b4ae6db50a63
Author: DmytroShkvyra <ds...@gmail.com>
Date: 2017-02-24T09:25:32Z
[ZEPPELIN-791] change comment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2032: [ZEPPELIN-791] Build infra: move all RAT to roo...
Posted by DmytroShkvyra <gi...@git.apache.org>.
GitHub user DmytroShkvyra reopened a pull request:
https://github.com/apache/zeppelin/pull/2032
[ZEPPELIN-791] Build infra: move all RAT to root pom.xml
What is this PR for?
It is better have a single place where we manage project-wise RAT exclusions for a contributions under licenses different from Apache, then let maven sub-modules have them as we do now (makes things harder to track)
What type of PR is it?
[Improvement]
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-791
How should this be tested?
mvn verify -DskipTests
Screenshots (if appropriate)
Questions:
Does the licenses files need update? - No
Is there breaking changes for older versions? - No
Does this needs documentation? - No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DmytroShkvyra/zeppelin ZEPPELIN-791
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2032
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2032: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2032
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2032: [ZEPPELIN-791] Build infra: move all RAT to roo...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra closed the pull request at:
https://github.com/apache/zeppelin/pull/2032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2032: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/zeppelin/pull/2032
Cant merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---