You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "WHChen-Alex (via GitHub)" <gi...@apache.org> on 2024/07/17 02:28:28 UTC
[PR] fix(trace): append http method to tags error when using the Header ob… [skywalking-client-js]
WHChen-Alex opened a new pull request, #131:
URL: https://github.com/apache/skywalking-client-js/pull/131
> ### Search before asking
> * [x] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
>
> ### Apache SkyWalking Component
> NodeJS Client Side Agent (apache/skywalking-client-js)
>
> ### What happened
> Relevant code: https://github.com/apache/skywalking-client-js/blob/master/src/trace/interceptors/fetch.ts#L116-L121
>
> <img alt="image" width="368" src="https://private-user-images.githubusercontent.com/2338946/342186559-9e6b4596-c107-48f7-a019-c0a828e48a5b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzI0MDYsIm5iZiI6MTcyMTEzMjEwNiwicGF0aCI6Ii8yMzM4OTQ2LzM0MjE4NjU1OS05ZTZiNDU5Ni1jMTA3LTQ4ZjctYTAxOS1jMGE4MjhlNDhhNWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTIxNTA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTRmZjIwNzAxODQ2YTAxZDU4ODljMmQ3MWUwODhjM2ZjODA5Y2U3OTRhNjZiYzRjMDVmOThhNDRjYjc3YjNlNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.uwVZ6lqrOQYGDpWmN5lYy0OAW-hNM9_ofVfGKElA2ug">
> If we call fetch with a Request object which contains headers, these headers will be throw error if enable skywalking-client-js.
>
> ```js
> const req = new Request("/api/projects", {
> headers: {
> "my-custom-header": "test",
> },
> });
>
> fetch(req);
> ```
>
> ### What you expected to happen
> Fix error
>
> ### How to reproduce
> https://codesandbox.io/p/devbox/wh2zsm?file=%2Fpackage.json&migrateFrom=sjygtk
>
> Open the devtools, switch to network tab, filter Fetch/XHR, open details for the request `/api/projects`, in Request Headers, and switch to console tab , see that error below
>
> ### Anything else
> _No response_
>
> ### Are you willing to submit a pull request to fix on your own?
> * [x] Yes I am to submit a pull request on my own!
>
> ### Code of Conduct
> * [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trace): append http method to tags error when using the Header ob… [skywalking-client-js]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #131:
URL: https://github.com/apache/skywalking-client-js/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trace): append http method to tags error when using the Header ob… [skywalking-client-js]
Posted by "WHChen-Alex (via GitHub)" <gi...@apache.org>.
WHChen-Alex commented on PR #131:
URL: https://github.com/apache/skywalking-client-js/pull/131#issuecomment-2232309256
Can you release v0.13.0 for now or last few days, please?
thx~
@Fine0830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org