You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/03/13 19:14:06 UTC
[GitHub] [knox] rlevas opened a new pull request #72: KNOX-1820 - Cleanup
KeystoreService implementations and add unit tests
rlevas opened a new pull request #72: KNOX-1820 - Cleanup KeystoreService implementations and add unit tests
URL: https://github.com/apache/knox/pull/72
## What changes were proposed in this pull request?
Removed the following unneeded classes:
- `org.apache.knox.gateway.services.security.impl.BaseKeystoreService`
- `org.apache.knox.gateway.services.security.impl.CMFKeystoreService`
- `org.apache.knox.gateway.services.security.impl.CMFKeystoreServiceTest`
Copied relevant members of `org.apache.knox.gateway.services.security.impl.BaseKeystoreService` to `org.apache.knox.gateway.services.security.impl.DefaultKeystoreService`.
Cleaned up `org.apache.knox.gateway.services.security.impl.DefaultKeystoreService`
- Utilized reusable code blocks
- Converted `java.io.File`s to `java.nio.file.Path`s
Added unit test cases to `org.apache.knox.gateway.services.security.impl.DefaultKeystoreServiceTest`
## How was this patch tested?
```
mvn -T.5C verify -Prelease,package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:02 min (Wall Clock)
[INFO] Finished at: 2019-03-13T15:01:33-04:00
[INFO] Final Memory: 270M/1891M
[INFO] ------------------------------------------------------------------------
```
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services