You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 18:50:00 UTC

[GitHub] [spark] xkrogen commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"

xkrogen commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926068031


   Thanks for reporting this @peter-toth !
   From a technical perspective the revert LGTM.
   I'm interested in fixing-forward -- either hiding this behind a feature flag, or adding logic to handle environment variables when extracting the values from the conf. I don't think either approach would require much time (could be completed by, say, tomorrow), but I understand if there is a desire to revert given that we are already in RC phase.
   
   cc @mridulm as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org