You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by we...@apache.org on 2022/06/17 11:02:04 UTC
[dolphinscheduler] branch dev updated: Open checkstyle, change checkstyle severity from info to warning (#10492)
This is an automated email from the ASF dual-hosted git repository.
wenjun pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 00f86da1da Open checkstyle, change checkstyle severity from info to warning (#10492)
00f86da1da is described below
commit 00f86da1da869b155de454f96c821360d4043fb2
Author: Wenjun Ruan <we...@apache.org>
AuthorDate: Fri Jun 17 19:01:54 2022 +0800
Open checkstyle, change checkstyle severity from info to warning (#10492)
* Open checkstyle, change checkstyle severity from info to warning
---
.github/workflows/api-test.yml | 2 +-
.github/workflows/e2e.yml | 2 +-
.github/workflows/publish-docker.yaml | 2 +-
.github/workflows/py-ci.yml | 2 +-
.github/workflows/unit-test.yml | 2 +-
style/checkstyle.xml | 7 ++++++-
6 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/api-test.yml b/.github/workflows/api-test.yml
index 3a60e68bb1..6462dfd9d2 100644
--- a/.github/workflows/api-test.yml
+++ b/.github/workflows/api-test.yml
@@ -65,7 +65,7 @@ jobs:
./mvnw -B clean install \
-Dmaven.test.skip \
-Dmaven.javadoc.skip \
- -Dmaven.checkstyle.skip \
+ -Dcheckstyle.skip=true \
-Pdocker,release -Ddocker.tag=ci \
-pl dolphinscheduler-standalone-server -am
- name: Export Docker Images
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 66d1214b5a..d5b22169fd 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -65,7 +65,7 @@ jobs:
./mvnw -B clean install \
-Dmaven.test.skip \
-Dmaven.javadoc.skip \
- -Dmaven.checkstyle.skip \
+ -Dcheckstyle.skip=true \
-Pdocker,release -Ddocker.tag=ci \
-pl dolphinscheduler-standalone-server -am
- name: Export Docker Images
diff --git a/.github/workflows/publish-docker.yaml b/.github/workflows/publish-docker.yaml
index 5774e166ad..5c3d5c4fdc 100644
--- a/.github/workflows/publish-docker.yaml
+++ b/.github/workflows/publish-docker.yaml
@@ -56,7 +56,7 @@ jobs:
./mvnw -B clean deploy \
-Dmaven.test.skip \
-Dmaven.javadoc.skip \
- -Dmaven.checkstyle.skip \
+ -Dcheckstyle.skip=true \
-Dmaven.deploy.skip \
-Ddocker.tag=${{ github.sha }} \
-Ddocker.hub=${{ env.HUB }} \
diff --git a/.github/workflows/py-ci.yml b/.github/workflows/py-ci.yml
index 2ec772b0b2..136c27ebab 100644
--- a/.github/workflows/py-ci.yml
+++ b/.github/workflows/py-ci.yml
@@ -137,7 +137,7 @@ jobs:
./mvnw -B clean install \
-Dmaven.test.skip \
-Dmaven.javadoc.skip \
- -Dmaven.checkstyle.skip \
+ -Dcheckstyle.skip=true \
-Pdocker,release -Ddocker.tag=ci \
-pl dolphinscheduler-standalone-server -am
- name: Export Docker Images
diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
index 02b03d5af8..71cd27e1e5 100644
--- a/.github/workflows/unit-test.yml
+++ b/.github/workflows/unit-test.yml
@@ -71,7 +71,7 @@ jobs:
key: ${{ runner.os }}-maven
- name: Run Unit tests
- run: ./mvnw clean verify -B -Dmaven.test.skip=false
+ run: ./mvnw clean verify -B -Dmaven.test.skip=false -Dcheckstyle.skip=true
- name: Upload coverage report to codecov
run: CODECOV_TOKEN="09c2663f-b091-4258-8a47-c981827eb29a" bash <(curl -s https://codecov.io/bash)
diff --git a/style/checkstyle.xml b/style/checkstyle.xml
index 08bb05b108..07a3aaf570 100644
--- a/style/checkstyle.xml
+++ b/style/checkstyle.xml
@@ -21,7 +21,9 @@
<module name="Checker">
<property name="charset" value="UTF-8"/>
- <property name="severity" value="info"/>
+ <property name="severity" value="warning"/>
+
+ <module name="SuppressWarningsFilter"/>
<property name="fileExtensions" value="java, properties, xml"/>
@@ -40,6 +42,9 @@
</module>
<module name="TreeWalker">
+
+ <module name="SuppressWarningsHolder"/>
+
<module name="OuterTypeFilename">
<property name="severity" value="error"/>
</module>