[GitHub] [spark] mattf-apache commented on a change in pull request #25315: [SPARK-28582][PYSPARK] Fix pyspark daemon exit failed when receive SIGTERM on Python 3.7

[GitBox <gi...@apache.org>]

mattf-apache commented on a change in pull request #25315: [SPARK-28582][PYSPARK] Fix pyspark daemon exit failed when receive SIGTERM on Python 3.7
URL: https://github.com/apache/spark/pull/25315#discussion_r309473635
 
 

 ##########
 File path: python/pyspark/daemon.py
 ##########
 @@ -102,7 +102,7 @@ def shutdown(code):
         signal.signal(SIGTERM, SIG_DFL)
         # Send SIGHUP to notify workers of shutdown
         os.kill(0, SIGHUP)
 
 Review comment:
   Since many other lines in this module are already using `os._exit()`, it is probably fine to use it here too.  I do wonder, though, if inserting a slight pause between the above call to `os.kill(0, SIGHUP)` and the call to exit might relieve the underlying issue, and allow proper cleanup in the children.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org