You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "vectorijk (via GitHub)" <gi...@apache.org> on 2023/05/31 08:45:00 UTC
[GitHub] [hudi] vectorijk opened a new pull request, #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
vectorijk opened a new pull request, #8853:
URL: https://github.com/apache/hudi/pull/8853
### Change Logs
Fix log classname in SqlQuerySingleResultPreCommitValidator
### Impact
log with correct class name
### Risk level (write none, low medium or high below)
none
### Documentation Update
none
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Change Logs and Impact were stated clearly
- [x] Adequate tests were added if applicable
- [x] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8853:
URL: https://github.com/apache/hudi/pull/8853#issuecomment-1570573816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514",
"triggerID" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"triggerType" : "PUSH"
}, {
"hash" : "85e964086c2334ef74cee8714cb1e064f372ef8e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85e964086c2334ef74cee8714cb1e064f372ef8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43ac807b0127d9b965394e59fcdf5cca4932b386 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514)
* 85e964086c2334ef74cee8714cb1e064f372ef8e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8853:
URL: https://github.com/apache/hudi/pull/8853#issuecomment-1570380201
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514",
"triggerID" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43ac807b0127d9b965394e59fcdf5cca4932b386 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8853:
URL: https://github.com/apache/hudi/pull/8853#issuecomment-1569847853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514",
"triggerID" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43ac807b0127d9b965394e59fcdf5cca4932b386 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8853:
URL: https://github.com/apache/hudi/pull/8853#issuecomment-1570517344
@vectorijk Thanks for your first contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8853:
URL: https://github.com/apache/hudi/pull/8853#issuecomment-1570841586
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514",
"triggerID" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"triggerType" : "PUSH"
}, {
"hash" : "85e964086c2334ef74cee8714cb1e064f372ef8e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17525",
"triggerID" : "85e964086c2334ef74cee8714cb1e064f372ef8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85e964086c2334ef74cee8714cb1e064f372ef8e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17525)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8853:
URL: https://github.com/apache/hudi/pull/8853#discussion_r1211767917
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/validator/SqlQuerySingleResultPreCommitValidator.java:
##########
@@ -68,9 +68,9 @@ protected void validateUsingQuery(String query, String prevTableSnapshot, String
}
Object result = newRows.get(0).apply(0);
if (result == null || !expectedResult.equals(result.toString())) {
- LOG.error("Mismatch query result. Expected: " + expectedResult + " got " + result + "Query: " + query);
+ LOG.error("Mismatch query result. Expected: " + expectedResult + " got " + result + " on Query: " + query);
throw new HoodieValidationException("Query validation failed for '" + query
- + "'. Expected " + expectedResult + " rows, Found " + result);
+ + "'. Expected " + expectedResult + " row, Found " + result);
Review Comment:
```suggestion
+ "'. Expected " + expectedResult + " row(s), Found " + result);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8853:
URL: https://github.com/apache/hudi/pull/8853#issuecomment-1569779773
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43ac807b0127d9b965394e59fcdf5cca4932b386 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8853:
URL: https://github.com/apache/hudi/pull/8853#issuecomment-1570586096
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514",
"triggerID" : "43ac807b0127d9b965394e59fcdf5cca4932b386",
"triggerType" : "PUSH"
}, {
"hash" : "85e964086c2334ef74cee8714cb1e064f372ef8e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17525",
"triggerID" : "85e964086c2334ef74cee8714cb1e064f372ef8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43ac807b0127d9b965394e59fcdf5cca4932b386 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17514)
* 85e964086c2334ef74cee8714cb1e064f372ef8e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17525)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vectorijk commented on a diff in pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "vectorijk (via GitHub)" <gi...@apache.org>.
vectorijk commented on code in PR #8853:
URL: https://github.com/apache/hudi/pull/8853#discussion_r1211963153
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/validator/SqlQuerySingleResultPreCommitValidator.java:
##########
@@ -68,9 +68,9 @@ protected void validateUsingQuery(String query, String prevTableSnapshot, String
}
Object result = newRows.get(0).apply(0);
if (result == null || !expectedResult.equals(result.toString())) {
- LOG.error("Mismatch query result. Expected: " + expectedResult + " got " + result + "Query: " + query);
+ LOG.error("Mismatch query result. Expected: " + expectedResult + " got " + result + " on Query: " + query);
throw new HoodieValidationException("Query validation failed for '" + query
- + "'. Expected " + expectedResult + " rows, Found " + result);
+ + "'. Expected " + expectedResult + " row, Found " + result);
Review Comment:
thanks @yihua ! addressed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #8853: [HUDI-6294] Fix log classname in SqlQuerySingleResultPreCommitValidator
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8853:
URL: https://github.com/apache/hudi/pull/8853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org