[GitHub] [iceberg] rdblue commented on a change in pull request #1351: Parquet: Ignore INT96 metrics while importing tables

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1351:
URL: https://github.com/apache/iceberg/pull/1351#discussion_r471811471



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetUtil.java
##########
@@ -103,6 +103,11 @@ public static Metrics footerMetrics(ParquetMetadata metadata, MetricsConfig metr
     for (BlockMetaData block : blocks) {
       rowCount += block.getRowCount();
       for (ColumnChunkMetaData column : block.getColumns()) {
+        if (column.getPrimitiveType().getPrimitiveTypeName() == PrimitiveType.PrimitiveTypeName.INT96) {
+          // skip metrics for INT96 timestamps

Review comment:
       We may want to include a justification for skipping: the stats are not reliable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org