[GitHub] [maven-surefire] kalgon commented on a change in pull request #342: [SUREFIRE-1659] Log4j logger in TestExecutionListener corrupts Surefire's STDOUT

[GitBox <gi...@apache.org>]

kalgon commented on a change in pull request #342:
URL: https://github.com/apache/maven-surefire/pull/342#discussion_r603340521



##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformStreamCorruptionIT.java
##########
@@ -49,12 +49,42 @@ public void warningIsNotEmitted() throws VerificationException
     {
         OutputValidator validator = unpack( "/surefire-1614-stream-corruption" )
                 .executeTest()
-                .verifyErrorFree( 1 );
+                .verifyErrorFree( 2 );

Review comment:
       You're right, this line should not have changed. I first tried to add a new test in `surefire-1614-stream-corruption` (that's where the `2` comes from) but in the end, I created a new mini-project in `surefire-1659-stream-corruption` because the easiest way to trigger the problem is to have a `junit-platform.properties` and a redirection from `java.util.logging` to any other logging framework (I tested with both log4j and slf4j/logback). I'll change that `2` back to `1` ASAP. Do you have any other remark?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org