You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:48:53 UTC
[GitHub] [groovy] eric-milles opened a new pull request #1328: GROOVY-7232: prefer methodMissing over declared method on next candidate
eric-milles opened a new pull request #1328:
URL: https://github.com/apache/groovy/pull/1328
Here is my discussed alternative that simplifies the implementation using `InvokerHelper#invokeMethod`. If a delegate or owner implements `methodMissing` it will be called instead of trying `invokeMethod` on the next in line. This is more consistent with the way property resolution works (see `Closure#getProperty`).
`StaticTypeCheckingVisitor` will need a block similar to the one added for GROOVY-7996 in order for static compilation to line up.
https://issues.apache.org/jira/browse/GROOVY-7232
**Note:** This does not address the change in behavior discussed here: https://github.com/apache/groovy/commit/640e9304fe8950400d94adaad474c0c341209df0#commitcomment-40953759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1328: GROOVY-7232: prefer methodMissing over declared method on next candidate
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1328:
URL: https://github.com/apache/groovy/pull/1328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1328: GROOVY-7232: prefer methodMissing over declared method on next candidate
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1328:
URL: https://github.com/apache/groovy/pull/1328#issuecomment-670826498
Merged, thanks. Agree we need to look further at static compilation cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org