You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/04/16 03:38:52 UTC
[GitHub] [incubator-pinot] mayankshriv commented on issue #5259: Support
Aggregation functions with multiple arguments.
mayankshriv commented on issue #5259: Support Aggregation functions with multiple arguments.
URL: https://github.com/apache/incubator-pinot/pull/5259#issuecomment-614397789
> Recommend directly passing TransformBlock to the AggregationFunction, where AggregationFunction can get the column needed, instead of fetching the data on caller side and creating the map.
Yeah, I thought about that as well. I feel having a map passes only the relevant content and makes the api more crisp and unit testable, and hence chose to create a Map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org