You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/08 14:58:47 UTC
[GitHub] [airflow] olivermeyer opened a new pull request #16327: Make job name check optional in SageMakerTrainingOperator
olivermeyer opened a new pull request #16327:
URL: https://github.com/apache/airflow/pull/16327
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #16299
In this PR I make it possible to avoid listing existing training jobs by adding a `check_if_job_exists` parameter to the SageMakerTrainingOperator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olivermeyer closed pull request #16327: Make job name check optional in SageMakerTrainingOperator
Posted by GitBox <gi...@apache.org>.
olivermeyer closed pull request #16327:
URL: https://github.com/apache/airflow/pull/16327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] shlomiken commented on pull request #16327: Make job name check optional in SageMakerTrainingOperator
Posted by GitBox <gi...@apache.org>.
shlomiken commented on pull request #16327:
URL: https://github.com/apache/airflow/pull/16327#issuecomment-988000909
thanks for this @olivermeyer , is there any plans doing that for processingJob /transformJob as well ?
i considered doing that myself - but i guess the kick start develop in this repo is not so quick is it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16327: Make job name check optional in SageMakerTrainingOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16327:
URL: https://github.com/apache/airflow/pull/16327#issuecomment-856843011
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16327: Make job name check optional in SageMakerTrainingOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16327:
URL: https://github.com/apache/airflow/pull/16327#issuecomment-859147260
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olivermeyer commented on pull request #16327: Make job name check optional in SageMakerTrainingOperator
Posted by GitBox <gi...@apache.org>.
olivermeyer commented on pull request #16327:
URL: https://github.com/apache/airflow/pull/16327#issuecomment-862223062
@kaxil thanks for reviewing. Is there anything else I need to do to get this merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org