[GitHub] vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234632039
 
 

 ##########
 File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java
 ##########
 @@ -291,27 +292,41 @@ public Table getTable(String name) {
       if (table != null) {
         return table;
       }
-      return inner.getTable(name.toUpperCase());
+      if (!areTableNamesCaseSensitive()) {
 
 Review comment:
   We can obtain `SqlDialect` for used DB, or use driver, specified in the config to determine the DB. But the behavior for some BDs may be configured [1], and I'm not sure that we can receive its values.
   I think it will be better to leave it as it is.
   
   [1] https://dev.mysql.com/doc/refman/8.0/en/identifier-case-sensitivity.html
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services