You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/10/19 11:57:05 UTC
[PR] GH-38346: Use new encrypted files for page index encryption test [arrow]
wgtmac opened a new pull request, #38347:
URL: https://github.com/apache/arrow/pull/38347
### Rationale for this change
Encrypted parquet files have been updated to apache/parquet-testing repo. We can use the new files to verify encrypted page index.
### What changes are included in this PR?
Minor refactor read_configurations_test.cc to check page index from all parquet files.
### Are these changes tested?
This is indeed a unit test enhancement.
### Are there any user-facing changes?
NO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38346: [C++][Parquet] Use new encrypted files for page index encryption test [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #38347:
URL: https://github.com/apache/arrow/pull/38347#issuecomment-1779945760
CI faileds are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38346: [C++][Parquet] Use new encrypted files for page index encryption test [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU merged PR #38347:
URL: https://github.com/apache/arrow/pull/38347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38346: Use new encrypted files for page index encryption test [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38347:
URL: https://github.com/apache/arrow/pull/38347#issuecomment-1770750895
:warning: GitHub issue #38346 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38346: [C++][Parquet] Use new encrypted files for page index encryption test [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #38347:
URL: https://github.com/apache/arrow/pull/38347#issuecomment-1778613027
Will merge it if nobody has more comment tonight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38346: [C++][Parquet] Use new encrypted files for page index encryption test [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #38347:
URL: https://github.com/apache/arrow/pull/38347#issuecomment-1778662661
Thank you @pitrou and @mapleFU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38346: [C++][Parquet] Use new encrypted files for page index encryption test [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38347:
URL: https://github.com/apache/arrow/pull/38347#issuecomment-1782358128
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit e8360615adf6c5a9bb76b81267d08388c7cfc3a9.
There were 9 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-10-25 20:26:51Z](https://conbench.ursa.dev/compare/runs/246b7fbd46f64e16a2aa8a227bb0684e...71aa633680104348a12b4310f6601e96/)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-16, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/065393121d667489800037f8a93b0191...0653996a61837c198000635016300574)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-10, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/065392e845f17c498000f3d8ce49bc37...0653993642c274cb80002874ffae01df)
- and 7 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/18109793874) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org