You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/07/23 19:53:02 UTC
Review Request 71143: Moved default constants for CSI RPC retry to a
new header.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71143/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254
Repository: mesos
Description
-------
Since the default constants for CSI RPC retry do not depend on CSI
versions, these constants are pulled off from version-specific headers
to a common header.
Diffs
-----
src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153
src/csi/constants.hpp PRE-CREATION
src/csi/v0_volume_manager.cpp e19dc7c2933e2bbee5e817f3089bd569b259786b
src/csi/v0_volume_manager_process.hpp 4cfb5b564af9e187a6e3d81f86964db288ae852e
src/csi/v1_volume_manager.cpp e7e032988bce576ef8d6a0c3457f26f1aad9bb58
src/csi/v1_volume_manager_process.hpp 30788c3593d4b4bd6271705a1188f73836bc7a85
src/tests/storage_local_resource_provider_tests.cpp 38233053452259571743317326a6efc74d97bd29
Diff: https://reviews.apache.org/r/71143/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 71143: Moved default constants for CSI RPC retry
to a new header.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71143/#review216810
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On July 23, 2019, 9:53 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71143/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 9:53 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the default constants for CSI RPC retry do not depend on CSI
> versions, these constants are pulled off from version-specific headers
> to a common header.
>
>
> Diffs
> -----
>
> src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153
> src/csi/constants.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp e19dc7c2933e2bbee5e817f3089bd569b259786b
> src/csi/v0_volume_manager_process.hpp 4cfb5b564af9e187a6e3d81f86964db288ae852e
> src/csi/v1_volume_manager.cpp e7e032988bce576ef8d6a0c3457f26f1aad9bb58
> src/csi/v1_volume_manager_process.hpp 30788c3593d4b4bd6271705a1188f73836bc7a85
> src/tests/storage_local_resource_provider_tests.cpp 38233053452259571743317326a6efc74d97bd29
>
>
> Diff: https://reviews.apache.org/r/71143/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 71143: Moved default constants for CSI RPC retry
to a new header.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71143/
-----------------------------------------------------------
(Updated July 26, 2019, 4:25 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Rebased.
Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254
Repository: mesos
Description
-------
Since the default constants for CSI RPC retry do not depend on CSI
versions, these constants are pulled off from version-specific headers
to a common header.
Diffs (updated)
-----
src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153
src/csi/constants.hpp PRE-CREATION
src/csi/v0_volume_manager.cpp e19dc7c2933e2bbee5e817f3089bd569b259786b
src/csi/v0_volume_manager_process.hpp 4cfb5b564af9e187a6e3d81f86964db288ae852e
src/csi/v1_volume_manager.cpp e7e032988bce576ef8d6a0c3457f26f1aad9bb58
src/csi/v1_volume_manager_process.hpp 30788c3593d4b4bd6271705a1188f73836bc7a85
src/tests/storage_local_resource_provider_tests.cpp 38233053452259571743317326a6efc74d97bd29
Diff: https://reviews.apache.org/r/71143/diff/2/
Changes: https://reviews.apache.org/r/71143/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao