You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Chen Maoqian (JIRA)" <ji...@apache.org> on 2016/04/25 04:15:13 UTC
[jira] [Updated] (ARTEMIS-501) Incorrect log message in class ClientSessionFactoryImpl

     [ https://issues.apache.org/jira/browse/ARTEMIS-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chen Maoqian updated ARTEMIS-501:
---------------------------------
    Description: 
There is incorrect logging message present in method establishNewConnection() in class org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl .

   protected RemotingConnection establishNewConnection() {
     ....
      RemotingConnection newConnection = clientProtocolManager.connect(...);
      newConnection.addFailureListener(new DelegatingFailureListener(newConnection.getID()));
      schedulePing();
      if (ActiveMQClientLogger.LOGGER.isTraceEnabled()) {
         ActiveMQClientLogger.LOGGER.trace("returning " + connection);
      }
      return newConnection;
   }

Log message says, that it is returning connection (old one, present as an attribute of class), but connection stored in newConnection variable is returned (and then it is set as this.connection).

  was:
There is incorrect logging message present in method establishNewConnection() in class org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl .

   protected RemotingConnection establishNewConnection() {
     ....
      RemotingConnection newConnection = clientProtocolManager.connect(...);
      newConnection.addFailureListener(new DelegatingFailureListener(newConnection.getID()));
      schedulePing();
      if (ActiveMQClientLogger.LOGGER.isTraceEnabled()) {
         ActiveMQClientLogger.LOGGER.trace("returning " + connection);
      }
      return newConnection;
   }

Log message says, that it is returning connection (old one, present as an attribute of class), but connection stored in newConnection variable is returned (and then it is set as this.connection).
Add Link


> Incorrect log message in class ClientSessionFactoryImpl
> -------------------------------------------------------
>
>                 Key: ARTEMIS-501
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-501
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 1.2.0
>            Reporter: Chen Maoqian
>             Fix For: 1.2.0
>
>
> There is incorrect logging message present in method establishNewConnection() in class org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl .
>    protected RemotingConnection establishNewConnection() {
>      ....
>       RemotingConnection newConnection = clientProtocolManager.connect(...);
>       newConnection.addFailureListener(new DelegatingFailureListener(newConnection.getID()));
>       schedulePing();
>       if (ActiveMQClientLogger.LOGGER.isTraceEnabled()) {
>          ActiveMQClientLogger.LOGGER.trace("returning " + connection);
>       }
>       return newConnection;
>    }
> Log message says, that it is returning connection (old one, present as an attribute of class), but connection stored in newConnection variable is returned (and then it is set as this.connection).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)