You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Dimitris Zenios <di...@gmail.com> on 2015/03/31 22:45:07 UTC

Tapestry 5.4-beta28 grid model

Hi everyone

Continuing on my previous post regarding grid default sort mixin,Does any
one know why in grid setupDataSource line 515 we clear the dataModel. This
function is called from setupRender of the grid.By clearing the model, any
changes done to the model by a mixin setup render, are removed and then
when recreating the model from setup render all sort of errors occur
(Example: BeanModelUtils.modify is called twice and since we do not allow
the same property to be added twice in a model an exception occures)

Any ideas?

Regards
Dimitris Zenios

Re: Tapestry 5.4-beta28 grid model

Posted by Dimitris Zenios <di...@gmail.com>.
Done along with a patch and a test case

https://issues.apache.org/jira/browse/TAP5-2470

On Wed, Apr 1, 2015 at 3:21 PM, Jochen Kemnade <jo...@eddyson.de>
wrote:

> Dimitris,
>
> Am 31.03.2015 um 22:45 schrieb Dimitris Zenios:
>
>> Continuing on my previous post regarding grid default sort mixin,Does any
>> one know why in grid setupDataSource line 515 we clear the dataModel.
>>
>
> Well, I haven't had a close look, but that line has been there for several
> years [1] and was part of the fix for TAP5-135 [2].
>
>  Any ideas?
>>
>
> I guess the line should probably be placed in the cleanupRender() method
> rather than in setupRender(). Could you please create a JIRA issue?
>
> Jochen
>
> [1] https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=
> commitdiff;h=629095afaeb23e9032fe074194e48d4a908cb81c
> [2] https://issues.apache.org/jira/browse/TAP5-135
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>

Re: Tapestry 5.4-beta28 grid model

Posted by Jochen Kemnade <jo...@eddyson.de>.
Dimitris,

Am 31.03.2015 um 22:45 schrieb Dimitris Zenios:
> Continuing on my previous post regarding grid default sort mixin,Does any
> one know why in grid setupDataSource line 515 we clear the dataModel.

Well, I haven't had a close look, but that line has been there for 
several years [1] and was part of the fix for TAP5-135 [2].

> Any ideas?

I guess the line should probably be placed in the cleanupRender() method 
rather than in setupRender(). Could you please create a JIRA issue?

Jochen

[1] 
https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=commitdiff;h=629095afaeb23e9032fe074194e48d4a908cb81c
[2] https://issues.apache.org/jira/browse/TAP5-135


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org